July 2011 - Wine-Devel - list.winehq.org

Re: [1/2] cmd/tests: Add tests for recursive rmdir
by Marvin July 15, 2011

July 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12505 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc1def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel nonzero, bad', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7

2 1

Re: [PATCH 10/11] wscript: implemented Host_get_Interactive
by Jacek Caban July 15, 2011

July 15, 2011

Hi Michał, On 07/15/11 03:22, Michał Ziętek wrote: > --- > programs/wscript/host.c | 7 +++++-- > programs/wscript/main.c | 26 +++++++++++++++++++++++++- > programs/wscript/wscript.h | 2 ++ > 3 files changed, 32 insertions(+), 3 deletions(-) > +static const WCHAR* get_arg_beginning(const WCHAR* arg) +{ + const WCHAR *beg = arg; + while(*beg == '/' || *beg == '-') { + ++beg; + } + return beg; +} This won't do what you want it to. Jacek

1 0

Re: shell32: Fix cast in RecycleBinMenu_InvokeCommand
by Alexandre Julliard July 14, 2011

July 14, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > @@ -240,7 +240,7 @@ static HRESULT WINAPI RecycleBinMenu_InvokeCommand(IContextMenu2 *iface, > LPCSTR verb = pici->lpVerb; > if(!HIWORD(verb)) > { > - switch((UINT)verb) > + switch((UINT_PTR)verb) Actually the HIWORD() is more problematic. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32: Make ISFHelper_fnCopyItems actually copy the items (try 2)
by Alexandre Julliard July 14, 2011

July 14, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > Removed an unused variable. Still failing ("ret may be used uninitialized"). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] d3dx9_36: Added support for structs and arrays to ID3DXConstantTable (Try 2)
by Matteo Bruni July 14, 2011

July 14, 2011

2011/7/14 Travis Athougies <iammisc(a)gmail.com>: > Needed for Assassin's Creed Brotherhood and Dead Space 2. > > Changes from last patch: > - New way of distinguishing handles from strings > - Support for parent constants in ID3DXConstantTable::GetConstantByName and ID3DXConstantTable::GetConstant > - Implemented ID3DXContantTable::GetConstantElement > You should split the reworking of D3DXHANDLEs into a separate patch. GetConstantElement could be on its own patch too, probably.

1 0

Bad flag check
by Francois Gouget July 14, 2011

July 14, 2011

One of my scripts noticed that the following code does not make sense in dlls/winmm/waveform.c: static DWORD WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, DWORD_PTR param2) { if(info->flags & DCB_NULL) return MMSYSERR_NOERROR; That's because DCB_NULL is 0 so this condition is always false. What was the intent? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

2 1

Fwd: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell July 14, 2011

July 14, 2011

Hi Stefan sorry for the duplicate email. I forgot to also send it to wine-devel. On Fri, Jun 17, 2011 at 12:02 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 16 June 2011 10:49:19 Michael Mc Donnell wrote: >> I've added the test you outlined. It shows you're correct that >> GetDeclaration only writes up to D3DDECL_END(). I've changed the >> implementation so that it caches the number of elements and only >> writes up to D3DDECL_END(). > Looks good to me. Great! >> You're right it could potentially read undefined memory depending on >> the compiler semantics. I think the safest thing is just to read up to >> D3DDECL_END() in the passed in declaration, then it will never read >> undefined memory (except if the programmer makes a mistake). > Looks good, but please write a WARN message in every case where you return an > error to the application. We believe that we handled the error condition > correctly, so there's no need for a FIXME, but the broken app behavior may > have been triggered by some other problem in Wine, so the message is more > important than a simple TRACE. Ok I've added WARN message for every case where it returns an error to the application. I've also reworded the WARN where it uses an invalid declaration but still must return D3D_OK.

4 36

Visual Studio project to compile the d3d code
by Stefan Dösinger July 14, 2011

July 14, 2011

Hi, After two people told me they might have use for my Visual Studio setup to compile wined3d I finally got around to put it on my git server. You can download it with GIT_SSL_NO_VERIFY=1 git clone https://84.112.174.163/~git/wined3d_vs What is this good for? My aims were to have Microsoft-Style debug symbols to use various Windows development tools. The also aim was to to work without Mingw, Msys or any other Unix tool besides git, mostly because mingw+msys is a pain. It performs an out-of-tree build of ddraw, d3d8, d3d9, the tests, wined3d and a few dependencies. Just put the files next to the wine sources, the project essentially loads the source files from ../wine/*. I also have d3dx9_36.dll in the project, but it doesn't link at the moment because d3dcompiler.dll is missing and some math functions. The testlist.c files for the tests cannot be autogenerated yet. The main issue is that this project is a stripped-down reimplementation of the wine build system. The source files and library exports are hardcoded, so if they change the msvc project needs manual adjustments. It would be much nicer to use the msvcmaker script for that, but I wasn't aware of this script when I started this. No additional software besides Visual Studio 2010 is needed, except for d3dx9_36 which needs the DirectX SDK. I just noticed that the d3d8 tests hardcode a path to the SDK sdk too, that is a bug that I can fix. I tried to compile the tests and d3d client libs with the MS headers to test our header compatibility but ran into some difficulties. The generated binaries also have no dependencies except the msvc2010 C runtime(msvcr100.dll) One word about licensing: I didn't find any obstacles that prevent personal use of MSVC Express, but please double-check the EULAs. Redistribution of Microsoft code is a problem however. The project setup doesn't deliberately include any MS code in the binaries, but it is possible that some functions from the C runtime is inlined, so to stay on the safe side I don't redistribute any binaries built from Visual Studio. There are a bunch of warnings left in the code. I fixed the warnings in wined3d.dll, d3d8.dll, d3d9.dll and the d3d8 tests, or silenced some warnings that I considered too pedantic or hard to fix. ddraw.dll, the ddraw tests and d3dx9 and the d3d9 tests have a number of legitimate warnings left. Stefan

2 5

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 14, 2011

July 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12469 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout === W2K3R2SESP2 (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c000000d pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === WVISTAADM (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W2K8SE (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W7PRO (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 pipe.c:378: Test failed: IOAPC ran too early

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin July 14, 2011

July 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12472 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0