July 2011 - Wine-Devel - list.winehq.org

Re: mshtml: Implment IHTMLDocument2 elementFromPoint
by Jacek Caban July 18, 2011

July 18, 2011

Hi Alistair, On 07/18/11 06:29, Alistair Leslie-Hughes wrote: > Hi, > Fixmes http://bugs.winehq.org/show_bug.cgi?id=27682 > > > Changelog: > mshtml: Implment IHTMLDocument2 elementFromPoint > First of all, tests please. + nsIDOMElement *nselem = NULL; + nsresult nsres; + HRESULT hres; + HTMLDOMNode *node; You use tabs in the whole patch. + nsIDOMNSDocument *pNSDoc; Please don't add such variable names. Jacek

1 0

Re: mshtml: Handle the failure case in get_nsstyle_attr.
by Jacek Caban July 18, 2011

July 18, 2011

Hi Gerald, On 07/15/11 22:49, Gerald Pfeifer wrote: > --- > dlls/mshtml/htmlstyle.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index cd1f6b5..3e76e61 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -468,6 +468,8 @@ HRESULT get_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, BSTR > > nsAString_GetData(&str_value, &value); > hres = nsstyle_to_bstr(value, flags, p); > + if( FAILED(hres) ) > + return hres; > nsAString_Finish(&str_value); Good catch, but you add a leak here. Jacek

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12563 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: ole32: Remove dead code.
by Nikolay Sivov July 18, 2011

July 18, 2011

On Mon, Jul 18, 2011 at 9:43 AM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > > MSHLFLAGS_NORMAL == 0. > --- > dlls/ole32/compobj_private.h | 4 +--- > dlls/ole32/stubmanager.c | 19 ++----------------- > 2 files changed, 3 insertions(+), 20 deletions(-) > > Maybe it should be like 'flags == MSHLFLAGS_NORMAL' ?

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12529 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/12] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12527 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in an nonalertable mode
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12526 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: Glitch-free iTunes?
by Dan Kegel July 16, 2011

July 16, 2011

Keith wrote: > http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… > Can you make a goal of supporting iTunes with no glitches? ... > Just this one app could be huge for Linux on the desktop. The main problem is driver support, I think (mainly usb, but probably also cd-r). There is some work on usb support going on; see http://wiki.winehq.org/USB I haven't tried that myself. (Has anyone tried this with iTunes yet?) According to $ winedump -j import ~/".wine/drive_c/Program Files/Common Files/Apple/Mobile Device Support/Drivers/usbaapl.sys" | grep offset offset 00009250 ntoskrnl.exe offset 00009264 HAL.dll offset 00009278 WMILIB.SYS offset 0000928c USBD.SYS support for wmilib.sys might need to be added for this app. And I suspect the pcworld guy was using an outdated version of wine (given the problems he reported with the package manager ui). Otherwise, current iTunes seems to be working reasonably well in current wine. I just downloaded and installed iTunes 10.3.1 with wine-1.3.23. I did have to set win7 mode, and I do have to click through one dialog saying it won't be able to burn cd's, but I can use the iTunes store to search for movies and play their trailers nicely; I can listen to internet radio or a local .mp3 for 5-10 minutes with no hint of trouble. So: yeah, we know it's an important app. But it's hard. Feel free to help out. - Dan

8 9

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in nonalertable mode
by Alexandre Julliard July 15, 2011

July 15, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/pipe.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so pipe.c && touch pipe.ok pipe.c:484: Test failed: ConnectNamedPipe pipe.c:494: Test failed: ReadFile pipe.c:497: Test failed: WriteFile pipe.c:503: Test failed: DisconnectNamedPipe Segmentation fault (core dumped) make: *** [pipe.ok] Error 139 -- Alexandre Julliard julliard(a)winehq.org

2 1