September 2014 - Wine-Devel

Re: wineps.drv: Fix bug using different enumeration value on user defined printer page sizes for printers using the same ppd.
by Huw Davies Sept. 23, 2014

Sept. 23, 2014

On Tue, Sep 23, 2014 at 11:09:39AM +0200, Ralf Habacker wrote: > diff --git a/dlls/wineps.drv/ppd.c b/dlls/wineps.drv/ppd.c > index 520355a..b440da0 100644 > --- a/dlls/wineps.drv/ppd.c > +++ b/dlls/wineps.drv/ppd.c > @@ -179,7 +179,6 @@ static const struct { > {NULL, 0} > }; > > -static WORD UserPageType = DMPAPER_USER; > static WORD UserBinType = DMBIN_USER; > > /*********************************************************************** > @@ -695,6 +694,7 @@ PPD *PSDRV_ParsePPD( const WCHAR *fname, HANDLE printer ) > char *def_pagesize_override = NULL, *def_duplex_override = NULL; > PAGESIZE *page, *page_cursor2; > struct map_context c; > + WORD UserPageType = DMPAPER_USER; > Right, but you want to move UserBinType too. Also, your commit message isn't great. Huw.

1 0

Re: [3/3] dpvoice: Add DirectPlay Voice Test
by Marvin Sept. 23, 2014

Sept. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9013 Your paranoid android. === w2000pro (32 bit voice) === voice.c:237: Test failed: Voice Connect failed with 0x80150183 === wxppro (32 bit voice) === voice.c:237: Test failed: Voice Connect failed with 0x80150183

1 0

Re: wined3d: Correctly display fog for right-handed projection matrix (try 2)
by Henri Verbeet Sept. 22, 2014

Sept. 22, 2014

On 18 September 2014 21:57, Joachim Priesner <joachim.priesner(a)web.de> wrote: > When using a right-handed projection matrix, z coordinates of vertices may be negative. This is not considered in the code generating the GLSL fog shader. The patch fixes that and adds a test. > The patch is likely correct, but the test has room for improvement. For example, it doesn't currently distinguish between using the absolute fog coordinate in the vertex shader or doing the same in the fragment shader. Also, please don't forget about ddraw and d3d8.

3 3

Re: vbscript: Don't try to convert int to short in return_int.
by Marvin Sept. 22, 2014

Sept. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8999 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] mshtml: add anchor element put_query and get_query
by Marvin Sept. 22, 2014

Sept. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8998 Your paranoid android. === w2000pro (32 bit dom) === dom.c:7368: Test failed: search = (null), expected ?word=abc dom.c:7379: Test failed: href = L"http://test/word=abc?how?old=are", expected http://test/?how?old=are#hash dom.c:7379: Test failed: value = L"http://test/word=abc?how?old=are", expected http://test/?how?old=are#hash

1 0

Re: [PATCH] dwrite: use correct variable (Coverity)
by Nikolay Sivov Sept. 21, 2014

Sept. 21, 2014

On 9/21/2014 16:35, Marcus Meissner wrote: > 1232720 Mixing enum types > > these are actually different values. > --- > dlls/dwrite/tests/font.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c > index 3a17064..fe4eb4b 100644 > --- a/dlls/dwrite/tests/font.c > +++ b/dlls/dwrite/tests/font.c > @@ -957,7 +957,7 @@ static void test_FontLoader(void) > ok(face == DWRITE_FONT_FACE_TYPE_UNKNOWN, "got %i\n", face); > ok(count == 0, "got %i\n", count); > > - hr = IDWriteFactory_CreateFontFace(factory, type, 1, &ffile, 0, 0, &fface); > + hr = IDWriteFactory_CreateFontFace(factory, face, 1, &ffile, 0, 0, &fface); > ok(hr == 0x8faecafe, "got 0x%08x\n", hr); > IDWriteFontFile_Release(ffile); > It's supposed to be DWRITE_FONT_FACE_TYPE_CFF (it is now) or DWRITE_FONT_FACE_TYPE_TRUETYPE.

2 1

Re: [PATCH] dwrite: use correct variable (Coverity)
by Marvin Sept. 21, 2014

Sept. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8996 Your paranoid android. === wvistau64 (32 bit font) === font.c:961: Test failed: got 0x80070057 === w2008s64 (32 bit font) === font.c:961: Test failed: got 0x80070057 === w7u (32 bit font) === font.c:961: Test failed: got 0x80070057 === w8 (32 bit font) === font.c:961: Test failed: got 0x80070057 === wvistau64 (64 bit font) === font.c:961: Test failed: got 0x80070057 === w2008s64 (64 bit font) === font.c:961: Test failed: got 0x80070057

1 0

Re: [PATCH] vbscript: Implemented RGB(try 2)
by Marvin Sept. 20, 2014

Sept. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8993 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented RGB
by Nikolay Sivov Sept. 19, 2014

Sept. 19, 2014

On 09/18/2014 08:46 PM, Shuai Meng wrote: > + LONG total, color[3];//color[0] for red, color[1] for green, color[2] for blue. This could be just 'int', as you use to_int(). > static HRESULT return_int(VARIANT *res, int val) > { > - if((short)val == val) > - return return_short(res, val); > - That's a questionable thing to do as it affects all other places where this helper is used. > + if(color[i] > 255) > + color[i] = 255; This needs a test too. > + total = color[0] + 256 * color[1] + 256 * 256 * color[2]; RGB() macro does the same thing.

4 6

Re: [3/3] gdiplus: Add a more optimized loop for composing onto PARGB.
by Andrew Eikum Sept. 19, 2014

Sept. 19, 2014

On Fri, Sep 19, 2014 at 11:28:13AM -0500, Vincent Povirk wrote: > + else if ((fg & 0xff000000) == 0xff) This will never be true. Andrew

2 1