- Wine-Devel - list.winehq.org

[PATCH 0/1] MR252: shell32/tests: Add tests for Program Manager name sanitization.
by Alex Henrie (＠alexhenrie) June 16, 2022

June 16, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/23 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/252

3 2

[PATCH 0/1] MR172: dlls/win32u: fix gcc12's warnings (UB)
by eric pouech (＠epo) June 16, 2022

June 16, 2022

GCC12.* emits tons of warnings when compiling win32'u sysparam bits These warnings stem from: - a union of different structures - allocating one instance of these structure and casting its address to a pointer to the union. This is UB as the whole union should be allocated in order to be a valid object. I tried to keep the original goals: - don't overallocate individual structures - have an OO design (and avoid casting back & forth arguments in methods) and implemented this fix by transforming (as argument to most of the methods) - a pointer to an union of structs into - an union (passed by value) of pointers to structs Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/172

3 4

[PATCH v4 0/6] MR73: Improvement in PDB's types record handling
by eric pouech (＠epo) June 16, 2022

June 16, 2022

This serie tackles several issues encountered while loading PDB files through dbghelp. It happens that PDB allows to have several type records for user defined types (struct / enums) with the same name. This seems to be generated by a) compiler (when modifying a structure definition between several compilation phases), b) the incremental linker (likely an optimisation of previous case, but not 100% certain when it's triggered). Wine's dbghelp ended up not picking the right record, hence generating errneous outputs. This series: - cleans up some PDB related code - update winedump to display the PDB hash table internals - fixes dbghelp to preserve in Wine's dbghelp hash table the partial order between type records of same name. v2: - rebased - removed a bunch of stray comments -- v4: dlls/dbghelp{pdb}: use remap table from PDB hash stream dlls/dbghelp{pdb}: ensure dbghelp's list order in hash table matches PDB's dlls/dbghelp{pdb}: clearly separate the type loading into two passes include/wine/mscvpdb.h: redefine property with bitfields dlls/dbghelp{pdb}: rely on first/last index from type header tools/winedump{pdb}: explore a bit more TPI hash elements https://gitlab.winehq.org/wine/wine/-/merge_requests/73

2 8

[PATCH 0/3] MR224: Fix GCC12 warnings
by eric pouech (＠epo) June 16, 2022

June 16, 2022

Fixes a couple of warnings emitted by GCC12 compiler -- https://gitlab.winehq.org/wine/wine/-/merge_requests/224

2 4

Wiki guidance on taking function prototypes from ReactOS
by Alex Henrie June 16, 2022

June 16, 2022

Yesterday I came across a bug report [1] with an attached patch to stub out the function RtlGetFullPathName_UEx, which is not documented by Microsoft, based on its prototype in ReactOS. Alexandre left the comment: [2] "You should not look at ReactOS code at all, a lot of it is reverse-engineered using methods that are not appropriate for Wine. It's not a usable source of information for us." The patch author, Ben, replied: [3] "I just want the WIKI to be MUCH more definitive/precise on what IS and IS NOT allowed." I took a look and as it currently stands, the wiki clearly encourages collaboration with ReactOS in at least one place: [4] "If you're still resisting the switch to unix for some reason though, you may have some luck investigating ReactOS (they cooperate with us on API issues too)." And it clearly discourages collaboration with ReactOS in at least one place: [5] "it appears that all such documentation is derived from ReactOS, which is not considered a legally safe source for use in Wine." Mention of ReactOS is conspicuously absent from the page that outlines Wine's "clean room" guidelines. [6] Since Alexandre says that Wine developers shouldn't look at ReactOS code at all, I think we should remove from the wiki all references that might be construed to encourage it and add some more that discourage it. Does anyone have any further thoughts before I start editing? -Alex [1] https://bugs.winehq.org/show_bug.cgi?id=50464 [2] https://bugs.winehq.org/show_bug.cgi?id=50464#c6 [3] https://bugs.winehq.org/show_bug.cgi?id=50464#c7 [4] https://wiki.winehq.org/Cygwin_and_More [5] https://wiki.winehq.org/AFD [6] https://wiki.winehq.org/Clean_Room_Guidelines

2 1

[PATCH 0/1] MR256: ntdll: Do not open directory file when setting the same directory path.
by Paul Gofman (＠gofman) June 16, 2022

June 16, 2022

Fixes The Rising of The Shield Hero: Relieve the Animation hangs on start (and maybe something else with ENIGMA protector). The protector implements virtual file system which hotpatches a lot of file related functions, in particular, NtOpenFile(). When NtOpenFile() is called from RtlSetCurrentDirectory_U() with peb lock held the hotpatcher takes its own lock and that can deadlock with other threads performing file / path operations ending up in get_full_path_helper() which also takes PEB lock. Once the hotpatcher is initialized the game only sets "." or the same full path as current and may do that rather often. It seems that reopening the file handle for the same directory is redundant anyway, so probably makes sense to just avoid that part. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/256

3 2

[PATCH 0/4] MR233: win32u: Partially move raw input APIs.
by Zebediah Figura (＠zfigura) June 16, 2022

June 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/233

5 26

[PATCH v4 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) June 16, 2022

June 16, 2022

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v4: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

2 3

[PATCH v2 0/5] MR131: wined3d: Introduce wined3d_device_check_format_support().
by Chip Davis (＠cdavis5e) June 15, 2022

June 15, 2022

Signed-off-by: Chip Davis <cdavis5x(a)gmail.com> -- v2: wined3d: Record format UAV capabilities. d3d11: Support D3D11_FEATURE_FORMAT_SUPPORT2. d3d11: Support D3D11_FEATURE_FORMAT_SUPPORT. d3d11: Reimplement ID3D11Device::CheckFormatSupport() using wined3d_device_check_format_support(). wined3d: Introduce wined3d_device_check_format_support(). https://gitlab.winehq.org/wine/wine/-/merge_requests/131

6 16

[PATCH v6 0/1] MR167: d3drm: IDirect3DRMMeshBuilder3::Load support loading from resource
by Alistair Leslie-Hughes (＠alesliehughes) June 15, 2022

June 15, 2022

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v6: d3drm: Pass all D3DRM_LOAD* flags directly through to CreateEnumObject() in IDirect3DRMMeshBuilder3::Load(). https://gitlab.winehq.org/wine/wine/-/merge_requests/167

4 3