January 2023 - Wine-GitLab - list.winehq.org

[PATCH v7 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) Jan. 25, 2023

Jan. 25, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v7: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH v2 0/6] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger Jan. 25, 2023

Jan. 25, 2023

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v2: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

4 10

[PATCH v8 0/2] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) Jan. 25, 2023

Jan. 25, 2023

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v8: vkd3d-shader/hlsl: Avoid infinite loop and invalid derefs in copy-prop. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

3 3

[PATCH v5 0/4] MR1801: secur32: schannel AcceptSecurityContext support
by Evan Tang (＠etang-cw) Jan. 25, 2023

Jan. 25, 2023

Adds support for AcceptSecurityContext to secur32 schannel Note: I'm not especially familiar with the secure channel API and mostly poked things until they worked. I can confirm it works well enough for [an application](https://store.steampowered.com/app/1787820/Mirror_Party/) using Microsoft's [Microsoft.Extensions.Hosting](https://learn.microsoft.com/en-us/dotnet/api/… .NET api to successfully negotiate a TLS connection with curl though. -- v5: secur32: Add test for schannel AcceptSecurityContext secur32: Fix schannel AcquireCredentialsHandle algorithm mismatch error return secur32: Share code for schannel Acquire and AcceptCredentialsHandle https://gitlab.winehq.org/wine/wine/-/merge_requests/1801

2 4

[PATCH v4 0/4] MR1801: secur32: schannel AcceptSecurityContext support
by Evan Tang (＠etang-cw) Jan. 25, 2023

Jan. 25, 2023

Adds support for AcceptSecurityContext to secur32 schannel Note: I'm not especially familiar with the secure channel API and mostly poked things until they worked. I can confirm it works well enough for [an application](https://store.steampowered.com/app/1787820/Mirror_Party/) using Microsoft's [Microsoft.Extensions.Hosting](https://learn.microsoft.com/en-us/dotnet/api/… .NET api to successfully negotiate a TLS connection with curl though. -- v4: secur32: Add test for AcceptSecurityContext https://gitlab.winehq.org/wine/wine/-/merge_requests/1801

2 4

Re: [PATCH v5 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) Jan. 25, 2023

Jan. 25, 2023

I don't think I tried, that's probably why I didn't mark it as such. Whether it's enough will depend on specific tx shader, and texture format. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_21829

1 0

Re: [PATCH v5 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Gijs Vermeulen (＠gverm) Jan. 25, 2023

Jan. 25, 2023

@nsivov Is this MR enough to fix [bug 48528](https://bugs.winehq.org/show_bug.cgi?id=48528)? If so, could you add a Wine-Bug tag to the last commit? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_21828

1 0

[PATCH v3 0/4] MR1801: secur32: schannel AcceptSecurityContext support
by Evan Tang (＠etang-cw) Jan. 25, 2023

Jan. 25, 2023

Adds support for AcceptSecurityContext to secur32 schannel Note: I'm not especially familiar with the secure channel API and mostly poked things until they worked. I can confirm it works well enough for [an application](https://store.steampowered.com/app/1787820/Mirror_Party/) using Microsoft's [Microsoft.Extensions.Hosting](https://learn.microsoft.com/en-us/dotnet/api/… .NET api to successfully negotiate a TLS connection with curl though. -- v3: secur32: Add test for AcceptSecurityContext secur32: Fix AcquireCredentialsHandle algorithm mismatch error return secur32: Share code for server and client versions of AcquireCredentialsHandle secur32: schannel AcceptSecurityContext support https://gitlab.winehq.org/wine/wine/-/merge_requests/1801

2 4

[PATCH v8 0/3] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) Jan. 25, 2023

Jan. 25, 2023

-- v8: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC) attributes to _recalloc. include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _aligned_malloc functions. include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

5 7

[PATCH v7 0/5] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) Jan. 25, 2023

Jan. 25, 2023

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v7: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface. windows.system.profile.systemmanufacturers: Add stub DLL. include: Add windows.system.profile.systemmanufacturers.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

3 7