November 2023 - Wine-GitLab

[PATCH 0/1] MR438: vkd3d-shader/tpf: Don't pass 0x4 as mask for vec4 constant src registers.
by Francisco Casas (＠fcasas) Nov. 2, 2023

Nov. 2, 2023

Evan Tang reported that new fixmes appeared on the shader_runner when running some of his tests after f50d0ae2cbc5ee2a26fedd7b8aac2def62decd6c. vkd3d:652593:fixme:shader_sm4_read_src_param Unhandled mask 0x4. The change to blame seems to be this added line in sm4_src_from_constant_value(). + src->swizzle = VKD3D_SHADER_NO_SWIZZLE; On tpf binaries the last 12 bytes of each src register in an instruction specify the swizzle, and there are 5 possible combinations: Dimension NONE -------- 00 Dimension SCALAR -------- 01 Dimension VEC4, with a 4 bit writemask: ---- xxxx 00 01 Dimension VEC4, with an 8 bit swizzle: xx xx xx xx 01 01 Dimension VEC4, with a 2bit scalar dimension number: ------ xx 10 01 So far, we have only seen src registers use 4 bit writemasks in a single case: for vec4 constants, and it is always zero. So we expect this: ---- 0000 00 01 Now, I probably wanted to initialize src->swizzle to zero when writing constants, but VKD3D_SHADER_NO_SWIZZLE is not zero, it is actually the default swizzle: 11 10 01 00 And the last 4 bits (0x4) get written in the mask part, which causes the reader to complain. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/438

3 2

[PATCH 0/4] MR437: tests: Add some tests for using technique blocks when compiling for pixel/vertex profiles.
by Nikolay Sivov (＠nsivov) Nov. 2, 2023

Nov. 2, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/437

5 7

[PATCH 0/1] MR440: vkd3d-shader/dxil: Allow empty struct types.
by Conor McCarthy (＠cmccarthy) Nov. 2, 2023

Nov. 2, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/440

4 3

[PATCH 0/1] MR433: vkd3d-shader/dxil: Always apply the signature element start column to used_mask.
by Conor McCarthy (＠cmccarthy) Nov. 2, 2023

Nov. 2, 2023

The used_mask value loaded from an additional tag/value pair is relative to the start column. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/433

4 5

[PATCH v6 0/8] MR432: ir: Validate TEMP registers.
by Giovanni Mascellani (＠giomasce) Nov. 2, 2023

Nov. 2, 2023

-- v6: vkd3d-shader/ir: Validate the index of a TEMP register. vkd3d-shader/ir: Validate the DCL_TEMPS instruction. vkd3d-shader/ir: Validate the register index count. vkd3d-shader/ir: Validate the register dimension. vkd3d-shader/ir: Validate the register data type. vkd3d-shader/ir: Validate the register precision. vkd3d-shader/dxil: Use vsir_register_init() to initialize registers. vkd3d-shader: Deduplicate profile version comparison functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/432

3 9

[PATCH v5 0/2] MR424: tests: Introduce a stress tester for vkd3d-shader.
by Giovanni Mascellani (＠giomasce) Nov. 2, 2023

Nov. 2, 2023

-- v5: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/424

3 4

[PATCH v6 0/4] MR423: vkd3d: Fix the macOS build.
by Giovanni Mascellani (＠giomasce) Nov. 2, 2023

Nov. 2, 2023

A few recent changes broke the macOS build. Unfortunately nobody noticed, because the macOS CI job always fails. :-( However, we can still fix that. I'm not sure that the last commit is the best approach, would like to have comments from Henri. -- v6: include: Import vkd3d_d3dcompiler.h instead of redefining D3D_BLOB_PART. ci: Make the MoltenVK logging less verbose. vkd3d-shader: Explicitly cast vkd3d_shader_global_flags to uint64_t. ci: Allow the artifact copy to fail. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/423

3 5

[PATCH v3 0/4] MR421: spirv: Remove some code no longer used after I/O normalization.
by Zebediah Figura (＠zfigura) Nov. 2, 2023

Nov. 2, 2023

-- v3: vkd3d-shader/spirv: No longer handle builtin array size mismatch in spirv_compiler_emit_input(). vkd3d-shader/spirv: Remove handling of VKD3DSPR_OUTCONTROLPOINT. vkd3d-shader/ir: Check for vocp usage during IR normalization. vkd3d-shader/ir: Pass a vkd3d_shader_parser to instruction_array_normalise_io_registers(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/421

3 6

[PATCH 0/4] MR4259: mshtml: More proper refs and leak fixes.
by Gabriel Ivăncescu Nov. 2, 2023

Nov. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4259

2 5

[PATCH v5 0/5] MR409: vkd3d-shader/dxil: Implement the DXIL BINOP instruction.
by Conor McCarthy (＠cmccarthy) Nov. 2, 2023

Nov. 2, 2023

-- v5: vkd3d-shader/dxil: Implement the DXIL BINOP instruction. vkd3d-shader/spirv: Support VKD3D_DATA_UINT in spirv_compiler_emit_neg(). vkd3d-shader/spirv: Handle the UMUL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/409

2 5