April 2023 - Wine-GitLab - list.winehq.org

[PATCH v5 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v5: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

2 10

[PATCH 0/4] MR2702: Radeon
by Stefan Dösinger April 25, 2023

April 25, 2023

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2702

2 6

[PATCH v4 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v4: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

2 13

[PATCH v3 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v3: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

1 10

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

Nikolay Sivov (@nsivov) commented about include/shtypes.idl: > SCALE_450_PERCENT = 450, > SCALE_500_PERCENT = 500 > } DEVICE_SCALE_FACTOR; > + > +typedef [v1_enum] enum tagSFBS_FLAGS { > + SFBS_FLAGS_ROUND_TO_NEAREST_DISPLAYED_DIGIT = 0x0001, > + SFBS_FLAGS_TRUNCATE_UNDISPLAYED_DECIMAL_DIGITS = 0x0002 > +} SFBS_FLAGS; I don't see this in current SDK, it's not defined in an idl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_31102

1 0

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

Nikolay Sivov (@nsivov) commented about dlls/shlwapi/string.c: > + { > + case SFBS_FLAGS_ROUND_TO_NEAREST_DISPLAYED_DIGIT: > + dBytes = round(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + case SFBS_FLAGS_TRUNCATE_UNDISPLAYED_DECIMAL_DIGITS: > + dBytes = floor(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + default: > + return E_INVALIDARG; > + } > > + /* Not sure about the error code. Can't find a way to trigger the error here */ > if (!FormatDouble(dBytes, bfFormats[i].nDecimals, lpszDest, cchMax)) > - return NULL; > + return E_UNEXPECTED; > + E_FAIL is probably more generic. Also comment is not really needed here. I'd also remove documentation comments before function declaration, leaving just function name there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_31101

1 0

[PATCH 0/4] MR2703: wineps: default device font, paths drawing and multiple pages document fixes
by Piotr Caban (＠piotr) April 25, 2023

April 25, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2703

4 6

[PATCH v4 0/5] MR2672: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) April 25, 2023

April 25, 2023

Needed for Minecraft Legends. -- v4: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0. twinapi.appcore: Add UnregisterAppStateChangeNotification stub. twinapi.appcore: Add RegisterAppStateChangeNotification stub. twinapi.appcore: Add stub DLL. include: Add appnotify.h file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2672

4 7

[PATCH v2 0/6] MR2628: Some more shell32 improvements.
by Jactry Zeng (＠jactry) April 25, 2023

April 25, 2023

-- v2: shell32: Update view mode flags while creating IShellView for IExplorerBrowser. shell32: Reimplement IExplorerBrowser_SetFolderSettings() with support of setting flags. shell32/tests: Move tests of IExplorerBrowser_SetFolderSettings() to a separated function and more tests. shell32: Reimplement IFolderView2_SetCurrentViewMode() with modern behaviours. shell32: Implement IFolderView2_{Get, Set}CurrentFolderFlags(). shell32/tests: Add tests for IFolderView2_{Get, Set}CurrentFolderFlags(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2628

2 7

[PATCH v2 0/2] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option().
by Vova Mshanetskiy (＠vovams) April 25, 2023

April 25, 2023

This is needed for mod.io integration in game "The Entropy Centre". Without support for this option the game hangs when trying to authenticate. Please note that i do not know how Wine works, and have very little understanding of what i am doing. I copied and adjusted code from `connect_query_option()` in the same file. The game does work with this patch though. -- v2: winhttp: Avoid unnecessary cast in connect_query_option(). winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

5 6