April 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR2581: winedump: Fix out of bounds access (spotted by GCC13). - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2581

1 0

Re: [PATCH v4 0/5] MR2486: D3D12 swapchain latency semaphore fixes - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2486

1 0

Re: [PATCH v5 0/1] MR137: vkd3d: Leave the command queue op mutex locked after a partial flush. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/137

1 0

[PATCH 0/5] MR2587: Support MF DXGI device manager in h264 decoder
by Paul Gofman (＠gofman) April 5, 2023

April 5, 2023

The last patch is a huge optimization to what is done in patch 2. Without that the sample is first copied from GPU to CPU each time wg_transform_read_mf() locks the buffer (allocating extra linear buffer on the way) and then copies the data back to GPU. That happens even if there is no sample available from wg_transform. With the last patch there is just one memory copy to the (write-only) locked DXGI surface buffer. And CPU to GPU texture transfer (which would be there anyway in most cases on software path as most of the apps are going to get the image to GPU anyway). In principle we could also skip the explicit staging texture and use _UpdateSubresource instead directly from h264 decoder, but this is currently not supported in wined3d for chroma formats and the overall difference between _UpdateSubresource and explicit mapped staging texture is not that great probably. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2587

4 17

[PATCH v2 0/2] MR2593: Draft: winex11.drv: Use the proper id with the settings handler.
by Alexandros Frantzis (＠afrantzis) April 5, 2023

April 5, 2023

The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Fixes: 4232312dffe1cd115aa6bfd755f5b7c6a403e3fc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54781 -- v2: winex11.drv: Do not call desktop get_current_mode() from UpdateDisplayDevices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 2

[PATCH 0/1] MR2593: Draft: winex11.drv: Use the proper id with the settings handler.
by Alexandros Frantzis (＠afrantzis) April 5, 2023

April 5, 2023

The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Fixes: 4232312dffe1cd115aa6bfd755f5b7c6a403e3fc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54781 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 3

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

Alexandre Julliard (@julliard) commented about dlls/ntdll/unix/file.c: > -static BOOL is_hidden_file( const UNICODE_STRING *name ) > +static BOOL is_hidden_file( const char *name ) > { > - WCHAR *p, *end; > + const char *p, *end; > > if (show_dot_files) return FALSE; > > - end = p = name->Buffer + name->Length/sizeof(WCHAR); > - while (p > name->Buffer && p[-1] == '\\') p--; > - while (p > name->Buffer && p[-1] != '\\') p--; > - return (p < end && *p == '.'); > + end = p = name + strlen( name ); > + while (p > name && p[-1] == '/') p--; > + while (p > name && p[-1] != '/') p--; > + return (p < end && p + 1 != end && p[0] == '.' && p[1] != '\\' && (p[1] != '.' || (p + 2 != end && p[2] != '\\'))); This doesn't make sense, it's using the wrong slashes and shouldn't be necessary in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29029

1 0

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

Alexandre Julliard (@julliard) commented about dlls/ntdll/tests/threadpool.c: > info2.ticks = 0; > > NtQuerySystemTime( &when ); > - when.QuadPart += (ULONGLONG)250 * 10000; > + when.QuadPart += (ULONGLONG)500 * 10000; > pTpSetTimer(timer2, &when, 0, 0); > - Sleep(50); > - when.QuadPart -= (ULONGLONG)150 * 10000; > - pTpSetTimer(timer1, &when, 0, 75); > + Sleep(100); > + when.QuadPart -= (ULONGLONG)300 * 10000; > + pTpSetTimer(timer1, &when, 0, 150); > > result = WaitForSingleObject(semaphore, 1000); Please don't add unrelated changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29028

1 0

[PATCH 0/12] MR2589: msvcrt: Use a few more functions from the bundled musl library.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2589

3 13

[PATCH v4 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) April 5, 2023

April 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v4: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

3 3