April 2023 - Wine-GitLab - list.winehq.org

[PATCH v4 0/3] MR2593: winex11.drv: UpdateDisplayDevice regression fixes
by Alexandros Frantzis (＠afrantzis) April 6, 2023

April 6, 2023

This MR contains two somewhat related commits/fixes for regressions that were made apparent in https://bugs.winehq.org/show_bug.cgi?id=54781. 1. The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). 2. The virtual desktop get_current_mode() implementation recurses into win32u (through NtUserGetPrimaryScreenRect) causing a deadlock if we call it from within UpdateDisplayDevices. There is a way to avoid the deadlock if we get the current_modes before calling add_gpu(), but we don't need to get and update the win32u current/registry in the virtual desktop case anyway, so skip the call completely instead. -- v4: winex11.drv: Use a distinct type for the settings id. winex11.drv: Do not call desktop get_current_mode() from UpdateDisplayDevices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 7

[PATCH v2 0/1] MR2599: dinput/tests: Mark some tests as flaky to workaround fvwm bug.
by Rémi Bernon April 6, 2023

April 6, 2023

I'm not 100% sure all of them are the same thing, and I can only reproduce one failure locally, but I suspect they might. In any case if the foreground window is wrong it's simply not going to work. -- v2: dinput/tests: Mark some tests as flaky to workaround fvwm bug. https://gitlab.winehq.org/wine/wine/-/merge_requests/2599

2 2

[PATCH v2 0/4] MR2587: Support MF DXGI device manager in h264 decoder
by Paul Gofman (＠gofman) April 6, 2023

April 6, 2023

The last patch is a huge optimization to what is done in patch 2. Without that the sample is first copied from GPU to CPU each time wg_transform_read_mf() locks the buffer (allocating extra linear buffer on the way) and then copies the data back to GPU. That happens even if there is no sample available from wg_transform. With the last patch there is just one memory copy to the (write-only) locked DXGI surface buffer. And CPU to GPU texture transfer (which would be there anyway in most cases on software path as most of the apps are going to get the image to GPU anyway). In principle we could also skip the explicit staging texture and use _UpdateSubresource instead directly from h264 decoder, but this is currently not supported in wined3d for chroma formats and the overall difference between _UpdateSubresource and explicit mapped staging texture is not that great probably. -- v2: winegstreamer: Pass temporary sample to wg_transform_read_mf() in h264 decoder. winegstreamer: Provide samples if DXGI device manager is set in h264 decoder. winegstreamer: Process MFT_MESSAGE_SET_D3D_MANAGER in h264 decoder. mf/tests: Test h264 decoder with dxgi device manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2587

4 11

[PATCH 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Mohamad Al-Jaf (＠maljaf) April 6, 2023

April 6, 2023

Needed for mingw Firefox build. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2595

2 1

[PATCH 0/1] MR2594: cryptowinrt/tests: Remove racey refcount test.
by Mohamad Al-Jaf (＠maljaf) April 6, 2023

April 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54783 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2594

3 2

[PATCH 0/1] MR2597: advapi32: Print ReportEvent() messages one line at a time.
by Zebediah Figura (＠zfigura) April 6, 2023

April 6, 2023

.NET Framework passes multiline backtraces to ReportEvent(), which get cut off when passed to debugstr_w(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2597

2 1

[PATCH v3 0/2] MR2593: Draft: winex11.drv: UpdateDisplayDevice regression fixes
by Alexandros Frantzis (＠afrantzis) April 6, 2023

April 6, 2023

This MR contains two somewhat related commits/fixes for regressions that were made apparent in https://bugs.winehq.org/show_bug.cgi?id=54781. 1. The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). 2. The virtual desktop get_current_mode() implementation recurses into win32u (through NtUserGetPrimaryScreenRect) causing a deadlock if we call it from within UpdateDisplayDevices. There is a way to avoid the deadlock if we get the current_modes before calling add_gpu(), but we don't need to get and update the win32u current/registry in the virtual desktop case anyway, so skip the call completely instead. -- v3: winex11.drv: Do not call desktop get_current_mode() from UpdateDisplayDevices. winex11.drv: Use the proper id with the settings handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

4 5

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) April 6, 2023

April 6, 2023

Hi Yeshun, you don't need to regularly rebase the MR on top of the latest master. Because this area of code is largely undocumented, to help this MR gets in, you need to add a test, even if it might not be easy. I think you can use some of the example codes in NCALRPC_example. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29113

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. - closed
by Alex Henrie (＠alexhenrie) April 6, 2023

April 6, 2023

This merge request was closed by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) April 6, 2023

April 6, 2023

On Tue Apr 4 19:02:38 2023 +0000, Zebediah Figura wrote: > It's hard for me to feel like this is an improvement, when we are now > adding an extra parameter to every call, and also using some > undocumented Windows functions that, to the reader, might have some > obscure different semantics. Based on that feedback, I am closing this merge request in favor of !2590, which at least gets rid of the duplicate implementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_29106

1 0