May 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/4] MR2931: uiautomationcore: Introduce helper function source file and more provider event adviser support.
by Connor McAdams (＠cmcadams) June 2, 2023

June 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2931

3 5

[PATCH v4 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Francisco Casas (＠fcasas) June 2, 2023

June 2, 2023

Indexing with non-constants offsets requires relative addressing in SM4. In assembly, this is written like in the following example: ``` x1[r1.x + 3] ``` The first part of this patch series only includes support for indexing vectors with non-constant indexes. Following patches in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-3. --- Non-constant indexing of vectors cannot be implemented with relative addressing in SM4 because this indexation cannot be performed at the level of register-components, only whole registers. Mathematical operations must be used instead. For floats, the native compiler seems to index an identity matrix, to get the i-th column, and then proceedes to compute the dot product between that column and the vector. For ints, bit operations seem to be performed. While probably less efficient, this implementation complies with the type-checking at the IR level and when writing bytecode. -- v4: vkd3d-shader/hlsl: Support non-constant vector indexing. vkd3d-shader/hlsl: Lower dot for non-float types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

3 6

[PATCH 0/6] MR2930: dxgi: Refactor D3D12 swapchain (first part)
by Giovanni Mascellani (＠giomasce) June 2, 2023

June 2, 2023

The D3D12 swapchain code is currently quite messy, probably because it was originally designed around the direct usage of the Vulkan swapchain images, then the support for user buffers was added, and the original design was later phased out. Currently the internal state can be divided in two different sets of objects: the "D3D12 side", which is visible to the `IDXGISwapChain` client and must be preserved at all times (except on the client's request, i.e., when `UpdateBuffers()` is called) and the "Vulkan side" which is private and can be destroyed and recreated more or less transparently (in case the Vulkan swapchain goes out of date or some settings are updated). This MR begins the process of de-intertwining the helpers that act on one or the other sides, so that the structure of the code is made clearer. The full patch set is at https://gitlab.winehq.org/giomasce/wine/-/commits/chianti. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2930

3 7

[PATCH v2 0/5] MR2944: winewayland.drv: First window contents on screen
by Alexandros Frantzis (＠afrantzis) June 2, 2023

June 2, 2023

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v2: winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 20

[PATCH 0/7] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu June 2, 2023

June 2, 2023

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

2 15

[PATCH v3 0/2] MR2866: server: Update parent window region when exposing previously invisible window. (#54949)
by Jinoh Kang (＠iamahuman) June 2, 2023

June 2, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54949 -- v3: server: Update parent window region when exposing previously invisible window. https://gitlab.winehq.org/wine/wine/-/merge_requests/2866

4 5

[PATCH 0/9] MR2934: sapi: Partially implement SpMMAudioOut.
by Shaun Ren (＠shaunren) June 2, 2023

June 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2934

4 12

[PATCH v4 0/3] MR2905: sapi: implement more token functionality.
by Shaun Ren (＠shaunren) June 2, 2023

June 2, 2023

-- v4: sapi: Implement token filtering and sorting in ISpObjectTokenEnumBuilder. sapi: Partially reimplement ISpObjectTokenEnumBuilder storing a token array. https://gitlab.winehq.org/wine/wine/-/merge_requests/2905

3 5

[PATCH v3 0/3] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon June 2, 2023

June 2, 2023

-- v3: ntdll: Add return address information in __wine_debug_context. ntdll: Add file and line information in __wine_debug_context. ntdll: Introduce struct __wine_debug_context for extensible debug info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

2 6

[PATCH v2 0/4] MR2830: Reimplement dbghelp.EnumerateLoadedModules.
by eric pouech (＠epo) June 2, 2023

June 2, 2023

The aim of this serie is to (re)implement dbghelp.EnumerateLoadedModules in order to return correct 32bit & 64bit modules information for a 32bit debuggee from a 64bit debugger. - In this case, Wine ntdll (incorrectly) stores the paths in LdrData (for system modules) within the syswow64 directory while native stores them within the system32 directory (except for 32bit ntdll which Wine correctly stores within system32). - So now dbghelp implements the system32 => syswow64 path rewrite (for the relevant cases), which is currently used only for ntdll. - This allows: - to be transparent in dbghelp if ntdll is fixed to store the same path as native - the paths returned by dbghelp are consistent with native (in the 64bit debugger / 32bit debuggee case mentionned above) It must be noted that the remaining todo:s in tests are only for the case of a 32bit debugger / 32bit debuggee in (old|new) wow setup, where the returned paths are the (untouched from ntdll) paths, hence in syswow64 when native reports them from system32. - this patch doesn't modify the returned path, and we haven't noticed any issue so far - with redirection in place, access to the image files should be tranparent - so we can keep it as is (not fixing ntdll). -- v2: dbghelp: Reimplement EnumerateLoadedModules(). dbghelp/tests: Add more test wrt. modules's imagename handling. dbghelp/test: Review old-wow64 expected values. dbghelp/tests: Fix process kind detection on old Windows machines. https://gitlab.winehq.org/wine/wine/-/merge_requests/2830

2 6