June 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR3013: wusa: Fix double free on error path in read_components (scan-build).
by Alex Henrie (＠alexhenrie) June 16, 2023

June 16, 2023

If read_identity returns FALSE, it has already called clear_identity. This is the same problem as in merge request !2970. Unfortunately I did not notice at first that the problem was present in two places. -- v3: wusa: Zero out identity on error path in read_identity. https://gitlab.winehq.org/wine/wine/-/merge_requests/3013

3 3

[PATCH v3 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 16, 2023

June 16, 2023

-- v3: wineoss: Call mmdevapi's get_application_name. winecoreaudio: Call mmdevapi's get_application_name. winealsa: Call mmdevapi's get_application_name. winepulse: Move get_application_name into mmdevapi. winepulse: Move AudioClient's Initialize's exclusive mode check into unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

3 7

[PATCH 0/3] MR3076: win32u: Use a specific flag instead of shrinking the clip rect.
by Rémi Bernon June 16, 2023

June 16, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55047 Shrinking the clipping rect to make sure we do not ignore the grab causes some issues. Instead, pass the set_cursor flags to the WM_WINE_CLIPCURSOR message, and introduce a new fullscreen window clipping flag. As described in the WineHQ bug, an alternative fix would be to keep the shrink but disable fullscreen grabs entirely when the option is disabled [*]. This would break the tests when the option is on but it is not the default. I think that this approach with a flag is better as it doesn't modify the clipping rect. [*] I don't think they are doing anything but I'm maybe missing something. Maybe grabbing the cursor over the entire virtual screen is preventing the cursor from going over host dock bars or something like that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3076

1 3

[PATCH v2 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO.
by Alex Henrie (＠alexhenrie) June 16, 2023

June 16, 2023

Fix memory leaks on error paths, don't call memset unnecessarily, and ensure that all output fields are initialized. -- v2: wldap32: Clean up LDAP_OPT_API_INFO. https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

3 4

[PATCH v2 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 16, 2023

June 16, 2023

-- v2: wineoss: Call mmdevapi's get_application_name. winecoreaudio: Call mmdevapi's get_application_name. winealsa: Call mmdevapi's get_application_name. winepulse: Move get_application_name into mmdevapi. winepulse: Move AudioClient's Initialize's exclusive mode check into unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

3 10

[PATCH v2 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) June 16, 2023

June 16, 2023

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.24, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- v2: winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 3

[PATCH 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) June 16, 2023

June 16, 2023

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.24, the last non-reforged release), and is consistent with the standard 32bit build. But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 2

Re: [PATCH v2 0/1] MR3072: winex11: Replace the clipping message HWND with a BOOL flag. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3072

1 0

Re: [PATCH v2 0/2] MR3071: winex11: Fix and simplify virtual desktop grabs and retries. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3071

1 0

Re: [PATCH v2 0/2] MR3070: win32u: Fix the DF_WINE_CREATE_DESKTOP desktop flag usage. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3070

1 0