June 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR3070: win32u: Fix the DF_WINE_CREATE_DESKTOP desktop flag usage. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3070

1 0

Re: [PATCH v2 0/1] MR3069: wininet: Free temporary buffer in InternetQueryOptionW loop. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3069

1 0

Re: [PATCH v3 0/1] MR3060: mmdevapi: Don't redefine stream_handle (gcc 4.3) - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3060

1 0

Re: [PATCH v2 0/1] MR2995: rpcrt4: Don't use GetProcAddress for ole32 functions. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2995

1 0

Re: [PATCH v2 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

1 0

[PATCH v5 0/6] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon June 15, 2023

June 15, 2023

-- v5: winex11: Report empty preedit string when result string is committed. winex11: Avoid breaking XIM sequence when merging mouse motion events. winex11: Avoid breaking XIM sequence when merging ConfigureNotify events. winex11: Introduce new handle_delayed_event helper. winex11: Move call_event_handler function around. winex11: Remove unnecessary process_events helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

2 9

Re: [PATCH v7 0/2] MR2958: mf: Various refcount leak fixes for session. - approved
by Alexandre Julliard (＠julliard) June 15, 2023

June 15, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

1 0

[PATCH v3 0/2] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) June 15, 2023

June 15, 2023

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v3: ws2_32/tests: Remove todo_wine from now-successful tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

2 2

[PATCH v9 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon June 15, 2023

June 15, 2023

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v9: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 11

[PATCH v24 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) June 15, 2023

June 15, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v24: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7