June 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Huw Davies (＠huw) June 8, 2023

June 8, 2023

That'll mean that the host's `TxViewChange` method would get called - we'd need a test to see if that's the case. It still seems like we're hiding the problem. What crash did you see when using `ME_WrapMarkedParagraphs()`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2941#note_35104

1 0

[PATCH v2 0/8] MR3009: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported, GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 8, 2023

June 8, 2023

-- v2: wineoss: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winecoreaudio: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winealsa: Use mmdevapi's AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize. winepulse: Move AudioClient's GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi. wineoss: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winecoreaudio: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winealsa: Use mmdevapi's AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported. winepulse: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3009

3 9

[PATCH 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO.
by Alex Henrie (＠alexhenrie) June 8, 2023

June 8, 2023

Fix memory leaks on error paths, don't call memset unnecessarily, and ensure that all output fields are initialized. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

3 4

[PATCH v2 0/6] MR3021: win32u: Move ClipCursor logic out of winex11.
by Rémi Bernon June 8, 2023

June 8, 2023

I wasn't completely sure what to do with the registry key. Keeping "Wine/X11 Driver" is a bit odd, but it also makes sure we stay backward compatible. Changing it would require more changes elsewhere and maybe it could be done later, if / when more options are moved. -- v2: win32u: Move fullscreen window cursor clipping from winex11. winex11: Move clip_fullscreen_window foreground check inside it. win32u: Add a clipping_cursor member to user_thread_info. win32u: Add a clipping_reset member to user_thread_info. win32u: Move grab_pointer registry option from winex11. winex11: Remove now unnecessary WM_X11DRV_CLIP_CURSOR_NOTIFY. https://gitlab.winehq.org/wine/wine/-/merge_requests/3021

1 7

[PATCH 0/6] MR3021: win32u: Move ClipCursor logic out of winex11.
by Rémi Bernon June 8, 2023

June 8, 2023

I wasn't completely sure what to do with the registry key. Keeping "Wine/X11 Driver" is a bit odd, but it also makes sure we stay backward compatible. Changing it would require more changes elsewhere and maybe it could be done later, if / when more options are moved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3021

2 7

[PATCH 0/3] MR3010: mf/tests: Split wmv decoder DMO tests.
by Ziqing Hui (＠zhui) June 8, 2023

June 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3010

4 6

[PATCH 0/1] MR3020: riched20: Update paragraph position in marked tree.
by Daniel Lehman (＠dlehman25) June 8, 2023

June 8, 2023

nCharOfs is the key for paragraphs added to the marked tree If it is updated, re-add the entry to update its position -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3020

4 3

[PATCH 0/8] MR3009: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's GetDevicePeriod, GetMixFormat, IsFormatSupported, GetCurrentPadding, GetStreamLatency, GetBufferSize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 8, 2023

June 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3009

3 10

[PATCH 0/1] MR3012: rpcrt4: Replace RPCRT4_strndupA with strdup.
by Alex Henrie (＠alexhenrie) June 8, 2023

June 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3012

3 2

Re: [PATCH v3 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Huw Davies (＠huw) June 8, 2023

June 8, 2023

Huw Davies (@huw) commented about dlls/sapi/uuid.c: > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "initguid.h" > + > +DEFINE_GUID(SPDFID_Text, 0x7ceef9f9, 0x3d13, 0x11d2, 0x9e, 0xe7, 0x00, 0xc0, 0x4f, 0x79, 0x73, 0x96); > +DEFINE_GUID(SPDFID_WaveFormatEx, 0xc31adbae, 0x527f, 0x4ff5, 0xa2, 0x30, 0xf6, 0x2b, 0xb6, 0x1f, 0xf7, 0x0c); Adding a new source file just for the guids seems a bit of an overkill. Can't we just add these to another file? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2992#note_35072

1 0