July 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/9] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon July 5, 2023

July 5, 2023

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

3 12

[PATCH v5 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu July 5, 2023

July 5, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v5: win32u: Don't clip fullscreen windows while capturing mouse pointer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

1 1

[PATCH v4 0/2] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu July 5, 2023

July 5, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v4: win32u: Don't clip fullscreen windows while capturing mouse pointer. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

2 6

[PATCH v14 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) July 5, 2023

July 5, 2023

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v14: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH v35 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) July 5, 2023

July 5, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v35: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 9

[PATCH v7 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl July 5, 2023

July 5, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v7: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

2 4

[PATCH v6 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl July 5, 2023

July 5, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v6: include: Add VoiceCommandSet runtimeclass with it's dependencies. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

3 9

[PATCH v5 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl July 5, 2023

July 5, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v5: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

1 4

[PATCH 0/21] MR221: Draft: vkd3d: Implement tiled resources
by Conor McCarthy (＠cmccarthy) July 5, 2023

July 5, 2023

Depends on branch tiled_resource1, MR 216. The first new commit is "Add tests for GetResourceTiling()." -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/221

2 22

[PATCH v4 0/3] MR383: widl: Add basic support for the [deprecated] attribute.
by Bernhard Kölbl July 5, 2023

July 5, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v4: include: Add VoiceCommandSet runtimeclass with it's dependencies. include: Add Windows.Phone.PhoneContract api contract. widl: Add basic support for the [deprecated] attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/383

2 5