July 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/10] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon July 6, 2023

July 6, 2023

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- v2: mf/tests: Add more media session transform tests with multiple inputs. mf/tests: Add more media session transform tests with multiple outputs. mf/tests: Add some media session transform call pattern tests. mf/session: Increase the stream request count when requests are already queued. mf/session: Request more samples from upstream when necessary. mf/session: Push transform input samples one by one to ProcessInput. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Flush requests in transform_node_deliver_samples when drained. mf/session: Use a helper to deliver transform node requested samples. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

2 12

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhao Yi (＠Zhaoyi) July 6, 2023

July 6, 2023

update the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38122

1 0

Re: [PATCH v3 0/1] MR3085: vbscript: Use correct pointer type in add_match (scan-build). - approved
by Jacek Caban (＠jacek) July 6, 2023

July 6, 2023

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3085

1 0

[PATCH v3 0/9] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) July 6, 2023

July 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54699 I added the complete `windows.networking.idl` file since it was small and in case it's needed for mingw build. -- v3: windows.networking.hostname: Implement IHostName::get_RawName(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3249

3 13

[PATCH v16 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl July 6, 2023

July 6, 2023

The test has a little inspiration from the SDK samples. -- v16: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

2 5

[PATCH v8 0/4] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) July 6, 2023

July 6, 2023

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. ~~But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code.~~ it works great, the issue with cinematics ended up being related to modesetting under xwayland, running with a virtual desktop in winecfg confirms playback working perfectly. -- v8: Fixup: define sized bool and enums in params Fixup: assert struct sizes with bool/enum Fixup: designated initializers winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

3 6

[PATCH 0/1] MR3252: dbghelp: Use nameless union/structs.
by eric pouech (＠epo) July 6, 2023

July 6, 2023

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3252

2 1

[PATCH 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)
by Fabian Maurer (＠DarkShadow44) July 6, 2023

July 6, 2023

When there are no caches, this variable would be uninitialized. Reported by clang-scan. Not sure if that can ever happen, but IMHO initializing doesn't do harm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

4 4

[PATCH 0/4] MR3251: secur32/tests: Fix a test failure.
by Hans Leidekker (＠hans) July 6, 2023

July 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55114 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3251

2 4

[PATCH 0/2] MR266: Document vkd3d_acquire_vk_queue() and vkd3d_release_vk_queue().
by Giovanni Mascellani (＠giomasce) July 6, 2023

July 6, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/266

3 3