July 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR3236: winhttp: Use specific types insted of sizeof(ULONG_PTR) in alloc_handle. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3236

1 0

Re: [PATCH v3 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

1 0

Re: [PATCH v2 0/1] MR3223: winspool: Declare JobW as a void pointer in SetJobA. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3223

1 0

Re: [PATCH v2 0/5] MR3240: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3240

1 0

Re: [PATCH v3 0/6] MR3204: ole/com Remove DECLSPEC_HIDDEN macro. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3204

1 0

Re: [PATCH v2 0/7] MR3233: Remove DECLSPEC_HIDDEN in DirectShow - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3233

1 0

Re: [PATCH v4 0/6] MR258: hlsl: Replace bare list pointers with hlsl_block, part 2. - approved
by Alexandre Julliard (＠julliard) July 5, 2023

July 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/258

1 0

[PATCH 0/9] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon July 5, 2023

July 5, 2023

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

3 12

[PATCH v5 0/1] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu July 5, 2023

July 5, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v5: win32u: Don't clip fullscreen windows while capturing mouse pointer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

1 1

[PATCH v4 0/2] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu July 5, 2023

July 5, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v4: win32u: Don't clip fullscreen windows while capturing mouse pointer. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

2 6