September 2023 - Wine-GitLab

[PATCH v4 0/9] MR317: vkd3d-shader: Begin validating the generated IR.
by Giovanni Mascellani (＠giomasce) Sept. 7, 2023

Sept. 7, 2023

The validation code is meant both as a check that the frontend is behaving properly and as a sort of the documentation to establish what is allowed and what is not in the IR. ~~Currently an assertion is thrown if validation fails. I realize this is a rather strong proposal, but it's of course up for debate. In theory asserting here is the right thing, as it is expected that the frontend is generating correct IR code. However vkd3d is already used in production for many programs, and it could very well be that some of those are working properly even if the generated IR is somewhat out of specs; allowing the assertion might cause regressions as soon as enough checks are implemented in the validator. Please let me know your opinions.~~ **Solved in favor of a softer failure, and only when validation is enabled** -- v4: vkd3d-shader: Validate source parameters. vkd3d-shader: Validate destination parameters. vkd3d-shader: Validate register types. vkd3d-shader: Validator instruction handlers. vkd3d-shader: Introduce a boilerplate to validate the generated IR. vkd3d-shader: Embed the parsing location in vkd3d_shader_instruction. vkd3d-shader: Destroy the SM6 parser on parsing errors. vkd3d-shader: Destroy the SM4 parser on parsing errors. vkd3d-shader: Destroy the SM1 parser on parsing errors. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

2 10

Re: [PATCH v4 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Nikolay Sivov (＠nsivov) Sept. 7, 2023

Sept. 7, 2023

Nikolay Sivov (@nsivov) commented about dlls/dwrite/tests/analyzer.c: > + { > + { 5, { L"\0test", 2, { > + { 0, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + { 1, 4, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + } } }, > + { 5, { L"te\0st", 3, { > + { 0, 2, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + { 2, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + { 3, 2, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + } } }, > + { 5, { L"test\0", 2, { > + { 0, 4, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + { 4, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + } } }, > + }; > const struct sa_test *ptr = sa_tests; Please put this to existing sa_tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744#note_44535

1 0

[PATCH 0/1] MR3752: d2d1: Respect stroke style D2D1_STROKE_TRANSFORM_TYPE_FIXED in DrawGeometry::ID2D1DeviceContext1().
by Dmitry Timoshkov (＠dmitry) Sept. 7, 2023

Sept. 7, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54368 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3752

3 3

[PATCH 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages.
by Dmitry Timoshkov (＠dmitry) Sept. 7, 2023

Sept. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

5 6

[PATCH 0/1] MR3750: user32: Listbox shouldn't send WM_COMMAND/LBN_DBLCLK notification if it has no items.
by Dmitry Timoshkov (＠dmitry) Sept. 7, 2023

Sept. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3750

2 1

[PATCH v50 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 7, 2023

Sept. 7, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v50: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/4] MR3749: wsdapi: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) Sept. 7, 2023

Sept. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3749

2 4

[PATCH v49 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 7, 2023

Sept. 7, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v49: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/1] MR3748: cmd: Reset ignoreBracket to FALSE when moving to the next line.
by Alex Henrie (＠alexhenrie) Sept. 6, 2023

Sept. 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55528 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3748

2 1

[PATCH v48 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 6, 2023

Sept. 6, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v48: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 9