September 2023 - Wine-GitLab

Re: [PATCH v4 0/2] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub.
by Helix Graziani (＠TornadoCookie) Sept. 6, 2023

Sept. 6, 2023

On Wed Sep 6 20:13:16 2023 +0000, Etaash Mathamsetty wrote: > btw your pull request isn't squashed and then merged, you have to squash > all the commits into one (since this is just a single stub). > To avoid merge commits use git rebase rather than git merge ah ok -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724#note_44466

1 0

[PATCH 0/1] MR3742: dmsynth/tests: Add the trailing linefeed to a win_skip() message.
by Francois Gouget (＠fgouget) Sept. 6, 2023

Sept. 6, 2023

The missing linefeed was causing the test summary line to be garbled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3742

3 2

[PATCH v2 0/8] MR3740: dmusic: Begin cleanup of collection and instruments parsing.
by Rémi Bernon Sept. 6, 2023

Sept. 6, 2023

-- v2: dmusic: Get rid of the IDirectMusicInstrumentImpl typedef. dmusic: Rename IDirectMusicInstrumentImpl method prefix to instrument. dmusic: Simplify and cleanup IDirectMusicInstrument constructor. dmusic: Get rid of struct collection liWavePoolTablePosition member. dmusic: Get rid of struct collection liCollectionPosition member. dmusic: Get rid of the IDirectMusicCollectionImpl typedef. dmusic: Rename IDirectMusicCollectionImpl method prefix to collection. dmusic: Move constructor parameter checks to class factory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3740

3 11

[PATCH v4 0/6] MR3738: dmsynth: Better implement sink latency clock and some activation methods.
by Rémi Bernon Sept. 6, 2023

Sept. 6, 2023

-- v4: dmsynth: Return DMUS_E_SYNTHNOTCONFIGURED when sink fails to activate. dmsynth: Return S_FALSE if IDirectMusicSynth_Activate is no-op. dmsynth: Forward IDirectMusicSynth_GetLatencyClock to the sink. dmsynth: Implement latency IReferenceClock interface on the sink. include: Use IReferenceClock interface from strmif.idl in dmusicc.h. dmsynth: Move constructor parameter checks to class factory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3738

2 7

[PATCH 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) Sept. 6, 2023

Sept. 6, 2023

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

3 3

[PATCH v7 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) Sept. 6, 2023

Sept. 6, 2023

-- v7: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

5 13

[PATCH v6 0/15] MR319: vkd3d-shader: Introduce vkd3d_shader_register.dimension, part 1.
by Francisco Casas (＠fcasas) Sept. 6, 2023

Sept. 6, 2023

This MR replaces `vkd3d_shader_register.immconst_type` with `vkd3d_shader_register.dimension` which is intended for all register types and not just immconsts. This dimension is parsed in tpf.c, and initialized according to the register type in d3dbc.c. Having this field in vkd3d_shader_register allows us to avoid hardcoding special cases for the register dimensions when writing sm4 bytecode (e.g. for the sampler src register in gather instructions). Also, it allows for some fixes to d3d_asm.c, which are introduced in part 2 (https://gitlab.winehq.org/fcasas/vkd3d/-/commits/add_vkd3d_reg_dim) -- v6: vkd3d-shader/d3dbc: Initialize register dimension for all register types. vkd3d-shader/tpf: Parse register dimension for all register types. vkd3d-shader: Turn vkd3d_shader_register.immconst_type into vkd3d_shader_register.dimension. vkd3d-shader/tpf: Use vsir_register_init() in shader_sm1_parse_dst_param(). vkd3d-shader/tpf: Use vsir_register_init() in shader_sm1_parse_src_param(). vkd3d-shader/tpf: Use vsir_register_init() in shader_sm4_read_param(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_default_control_point_phase(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_resource_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_sampler_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_dcl_immediate_constant_buffer(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_cbv_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_dcl_indexable_temp(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_hull_shader_builtins(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_get_invocation_id(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/319

4 18

[PATCH v3 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) Sept. 6, 2023

Sept. 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- v3: dwrite: Treat null character as NO_VISUAL in script analyzer. https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

2 1

Re: [PATCH v2 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Nikolay Sivov (＠nsivov) Sept. 6, 2023

Sept. 6, 2023

On Wed Sep 6 17:08:48 2023 +0000, Jeffrey Smith wrote: > Are you sure? It appears to be inconsistent with the styling for the > rest of the if condition. All other or-separated terms are using > parenthesis, regardless of whether they contain an &&. You're probably right. Let's leave it as is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744#note_44449

1 0

[PATCH 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) Sept. 6, 2023

Sept. 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

3 5