September 2023 - Wine-GitLab

[PATCH 0/4] MR3749: wsdapi: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) Sept. 7, 2023

Sept. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3749

2 4

[PATCH v49 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 7, 2023

Sept. 7, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v49: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/1] MR3748: cmd: Reset ignoreBracket to FALSE when moving to the next line.
by Alex Henrie (＠alexhenrie) Sept. 7, 2023

Sept. 7, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55528 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3748

2 1

[PATCH v48 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 7, 2023

Sept. 7, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v48: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 9

[PATCH v2 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) Sept. 6, 2023

Sept. 6, 2023

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v2: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

2 3

[PATCH 0/5] MR3747: kernelbase: Implement DeriveCapabilitySidsFromName().
by Paul Gofman (＠gofman) Sept. 6, 2023

Sept. 6, 2023

CEF sometimes uses that during sandbox initialization. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3747

2 6

[PATCH v3 0/2] MR3733: urlmon: test using http protocol through CreateBinding
by Yuxuan Shui (＠yshui) Sept. 6, 2023

Sept. 6, 2023

-- v3: urlmon: fix NULL dereference in BindProtocol_UnlockRequest urlmon: test http protocol through CreateBinding https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

4 4

Re: [PATCH v2 0/1] MR3745: user32/tests: Check all letters in test_hotkey. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2023

Sept. 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3745

1 0

Re: [PATCH v2 0/3] MR3743: gdiplus: In GdipImageSelectActiveFrame() rely on codec->select_func() to fail. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2023

Sept. 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3743

1 0

Re: [PATCH v3 0/8] MR3740: dmusic: Begin cleanup of collection and instruments parsing. - approved
by Alexandre Julliard (＠julliard) Sept. 6, 2023

Sept. 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3740

1 0