September 2023 - Wine-GitLab

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) Sept. 30, 2023

Sept. 30, 2023

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > DestroyWindow(hwnd); > } > > +static void test_ShouldSystemUseDarkMode(void) I think these tests might be a bit too much. I like the initial version that uses RegGetValueA() and confirms the registry value is the opposite of the ShouldSystemUseDarkMode. With some checks for the last error code and I think that's enough. These newly added tests confirm caching for ShouldSystemUseDarkMode() and that's good. However, ShouldSystemUseDarkMode() still need to query the registry key so it's not that useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47270

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) Sept. 30, 2023

Sept. 30, 2023

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; > + > + /* We don't necessarily care that this might fail because it doesn't affect > + * system_uses_light_theme if it does. > + */ While comments are nice to have, these are pretty obvious so I think you can ignore it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47269

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) Sept. 30, 2023

Sept. 30, 2023

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; You can remove the static keyword and always initialize system_uses_light_theme to TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47268

1 0

[PATCH v3 0/1] MR3984: configure: Don't link with -Wl,-z,defs on FreeBSD.
by Brendan Shanks (＠bshanks) Sept. 29, 2023

Sept. 29, 2023

On FreeBSD, using `environ` in a shared library linked with `-Wl,-z,defs` causes an undefined reference error: ``` gcc -m64 -o dlls/msv1_0/msv1_0.so -shared -Wl,-Bsymbolic -Wl,-soname,msv1_0.so -Wl,-z,defs dlls/msv1_0/unixlib.o dlls/ntdll/ntdll.so /usr/local/bin/ld: dlls/msv1_0/unixlib.o: in function `ntlm_fork': /usr/home/pip/wine/build64/../dlls/msv1_0/unixlib.c:206: undefined reference to `environ' collect2: error: ld returned 1 exit status *** Error code 1 ``` This is unfortunately a common issue on FreeBSD, see: - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263265 - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265008 - https://reviews.freebsd.org/D30842 Reported by Gerald Pfeifer. -- v3: configure: Don't use -Wl,-z,defs if causes link errors with 'environ'. https://gitlab.winehq.org/wine/wine/-/merge_requests/3984

3 2

[PATCH v7 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) Sept. 29, 2023

Sept. 29, 2023

Used in some .NET apps for theming purposes. -- v7: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 8

Re: [PATCH v2 0/9] MR3985: dmime, dmband: Implement GUID_ConnectToDLSCollection and band download. - approved
by Alexandre Julliard (＠julliard) Sept. 29, 2023

Sept. 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3985

1 0

Re: [PATCH v2 0/2] MR3981: shell32: Better handle long URLs. - approved
by Alexandre Julliard (＠julliard) Sept. 29, 2023

Sept. 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3981

1 0

Re: [PATCH v2 0/1] MR3980: windows.applicationmodel/tests: Use PathRemoveFileSpecW() instead of PathCchRemoveFileSpec(). - approved
by Alexandre Julliard (＠julliard) Sept. 29, 2023

Sept. 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3980

1 0

Re: [PATCH v6 0/3] MR3424: msxml3: Add ValidateOnParse property support. - approved
by Alexandre Julliard (＠julliard) Sept. 29, 2023

Sept. 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

1 0

Re: [PATCH v3 0/3] MR3986: include: Initial ARM64EC target support. - approved
by Alexandre Julliard (＠julliard) Sept. 29, 2023

Sept. 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3986

1 0