September 2023 - Wine-GitLab

Re: [PATCH v2 0/1] MR3914: winecoreaudio: Stop using the deprecated kAudioObjectPropertyElementMaster constant. - approved
by Alexandre Julliard (＠julliard) Sept. 21, 2023

Sept. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3914

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

On Thu Sep 21 20:34:12 2023 +0000, Aidan Khoury wrote: > I can for this, but we also need to check if it's a 32-bit image since > patch transforms are never applied to 64-bit images `RtlImageNtHeader` lacks proper image boundary checks for e_lfanew, so using it in this case is not safe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46247

1 0

[PATCH v32 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v32: mspatcha: Use unaligned typedefs for basic types mspatcha: Use string comparison for section names mspatcha: Add support for 32-bit file image patch transforms mspatcha: Add implementations for GetFilePatchSignature* routines mspatcha: Add support for 32-bit file normalization https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 8

[PATCH 0/2] MR3917: dmime: Implement sequence track parsing.
by Rémi Bernon Sept. 21, 2023

Sept. 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3917

2 4

[PATCH 0/3] MR3916: dmband: Rewrite band track parsing.
by Rémi Bernon Sept. 21, 2023

Sept. 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3916

3 6

[PATCH v31 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v31: mspatcha: Use unaligned typedefs for basic types mspatcha: Use string comparison for section names mspatcha: Relocate PE/COFF image functions mspatcha: Add support for 32-bit file image patch transforms mspatcha: Add implementations for GetFilePatchSignature* routines mspatcha: Add support for 32-bit file normalization https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 12

Re: [PATCH v3 0/5] MR356: Release 1.9. - approved
by Alexandre Julliard (＠julliard) Sept. 21, 2023

Sept. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/356

1 0

[PATCH v30 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v30: mspatcha: Use unaligned typedefs for basic types mspatcha: Use string comparison for section names https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

4 14

[PATCH v29 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v29: mspatcha: Use string comparison for section names mspatcha: Use unaligned typedefs for basic types https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 10

[PATCH v58 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) Sept. 21, 2023

Sept. 21, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v58: ws2_32/tests: Add test for AF_UNIX sockets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 8