January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR4932: sapi: Create a new engine only when needed in ISpVoice. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4932

1 0

Re: [PATCH v5 0/1] MR4973: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4973

1 0

[PATCH v6 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) Jan. 31, 2024

Jan. 31, 2024

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v6: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 6

[PATCH v5 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) Jan. 31, 2024

Jan. 31, 2024

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v5: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. vkd3d-shader/d3d-asm: Refactor dumping a write mask to a dedicated function. vkd3d-shader/d3d-asm: Describe the ASM dialect with a bunch of flags instead of a plain enum. vkd3d-shader/d3d-asm: Do not make a copy of the buffer before returning it. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 6

[PATCH v24 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen Jan. 31, 2024

Jan. 31, 2024

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v24: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 2

[PATCH v22 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen Jan. 31, 2024

Jan. 31, 2024

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v22: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 3

[PATCH 0/1] MR621: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate.
by Jacek Caban (＠jacek) Jan. 31, 2024

Jan. 31, 2024

Avoids value truncation in 32-bit builds and fixes clang warning: ``` ../libs/vkd3d/libs/vkd3d/device.c:2157:14: warning: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (size <= VKD3D_VA_SLAB_SIZE && allocator->free_slab) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/621

2 1

[PATCH 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes.
by Rémi Bernon Jan. 31, 2024

Jan. 31, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

2 6

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) Jan. 31, 2024

Jan. 31, 2024

On Wed Jan 31 20:20:40 2024 +0000, Rémi Bernon wrote: > Fwiw there is already an implementation of this in > `dlls/windows.media.speech/vector.c`, you should probably copy the > relevant parts of the file there. Will do, had no idea that existed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59718

1 0

[PATCH v6 0/11] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v6: debug dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 14

[PATCH v5 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v5: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Rémi Bernon Jan. 31, 2024

Jan. 31, 2024

Fwiw there is already an implementation of this in `dlls/windows.media.speech/vector.c`, you should probably copy the relevant parts of the file there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59714

1 0

[PATCH v4 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v4: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

[PATCH v3 0/9] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v3: dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

[PATCH 0/1] MR4976: tools: Implement strmake() using asprintf().
by Brendan Shanks (＠bshanks) Jan. 31, 2024

Jan. 31, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4976

2 2

[PATCH 0/5] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Jan. 31, 2024

Jan. 31, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

5 10

[PATCH 0/7] MR4986: mshtml: MessageEvent improvements and misc.
by Gabriel Ivăncescu Jan. 31, 2024

Jan. 31, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4986

2 8

[PATCH v10 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) Jan. 31, 2024

Jan. 31, 2024

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v10: mf/tests: Test IMFMediaSession::Start(). mf: Support seeking while a session is started. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 9

[PATCH v13 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon Jan. 31, 2024

Jan. 31, 2024

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v13: user32: Use the desktop shared data for GetCursorPos(). server: Expose the desktop shared mapping to clients. server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 17

[PATCH v2 0/7] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v2: dmime: Synthesize a band track for MIDI segments. dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime/test: add MIDI loading test dmime: Implement getting tempo param for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 26

[PATCH 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) Jan. 31, 2024

Jan. 31, 2024

Fixes https://bugs.winehq.org/show_bug.cgi?id=55167. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

2 1

[PATCH v4 0/2] MR601: Draft: vkd3d-shader/dxil: Implement DX intrinsic TextureLoad.
by Conor McCarthy (＠cmccarthy) Jan. 31, 2024

Jan. 31, 2024

Goes atop !583. The last two commits belong to this MR. -- v4: vkd3d-shader/spirv: Emit a vector bitcast if necessary in spirv_compiler_emit_load_ssa_reg(). vkd3d-shader/dxil: Implement DX intrinsic TextureLoad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/601

3 4

[PATCH 0/7] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) Jan. 31, 2024

Jan. 31, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 9

[PATCH v3 0/6] MR4906: mf,mfplat: Clang warning fixes.
by Jacek Caban (＠jacek) Jan. 31, 2024

Jan. 31, 2024

-- v3: mfmediaengine: Avoid implicit casts in IMFAttributes_GetUINT32 calls. mfmediaengine/tests: Use MF_MEDIA_ENGINE_CANPLAY type in IMFMediaEngine_CanPlayType call. mfplat: Introduce media_type_get_uint32 helper. mfplat/tests: Use MF_ATTRIBUTE_TYPE type in IMFMediaType_GetItemType call. mfplat: Avoid implicit cast in IMFAttributes_GetUINT32 call. mf: Avoid implicit enum to int pointer casts. https://gitlab.winehq.org/wine/wine/-/merge_requests/4906

3 10

[PATCH 0/1] MR4984: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop
by Fan WenJie (＠fanwenjie) Jan. 31, 2024

Jan. 31, 2024

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4984

2 1