January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Also I think it'd be better to split the include changes from the stub implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58325

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > + factory_GetRuntimeClassName, > + factory_GetTrustLevel, > + /* IActivationFactory methods */ > + factory_ActivateInstance, > +}; > + > +DEFINE_IINSPECTABLE( inputpane_interop, IInputPaneInterop, struct inputpane_statics, IActivationFactory_iface ); > + > +static HRESULT WINAPI inputpane_interop_GetForWindow(IInputPaneInterop *iface, HWND window, REFIID riid, void **inputpane) > +{ > + struct inputpane_statics *impl = impl_from_IInputPaneInterop(iface); > + > + TRACE("(window %p, riid %s, inputpane %p)\n", window, debugstr_guid( riid ), inputpane); > + > + factory_ActivateInstance(&impl->IActivationFactory_iface, (IInspectable**)inputpane); > + return S_OK; ```suggestion:-7+0 static HRESULT WINAPI inputpane_interop_GetForWindow( IInputPaneInterop *iface, HWND window, REFIID riid, void **inputpane ) { struct inputpane_statics *impl = impl_from_IInputPaneInterop( iface ); TRACE( "window %p, riid %s, inputpane %p\n", window, debugstr_guid( riid ), inputpane ); factory_ActivateInstance( &impl->IActivationFactory_iface, (IInspectable **)inputpane ); return S_OK; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58324

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > + inputpane_add_Showing, > + inputpane_remove_Showing, > + inputpane_add_Hiding, > + inputpane_remove_Hiding, > + inputpane_OccludedRect, > +}; > + > +DEFINE_IINSPECTABLE( inputpane2, IInputPane2, struct inputpane, IInputPane_iface ); > + > +static HRESULT WINAPI inputpane2_TryShow(IInputPane2 *iface, boolean *result) > +{ > + FIXME( "iface %p, result %p stub!\n", iface, result ); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI inputpane2_TryHide(IInputPane2 *iface, boolean *result) ```suggestion:-0+0 static HRESULT WINAPI inputpane2_TryHide( IInputPane2 *iface, boolean *result ) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58323

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > + /* IInspectable methods */ > + inputpane_GetIids, > + inputpane_GetRuntimeClassName, > + inputpane_GetTrustLevel, > + > + /* IInputPane methods */ > + inputpane_add_Showing, > + inputpane_remove_Showing, > + inputpane_add_Hiding, > + inputpane_remove_Hiding, > + inputpane_OccludedRect, > +}; > + > +DEFINE_IINSPECTABLE( inputpane2, IInputPane2, struct inputpane, IInputPane_iface ); > + > +static HRESULT WINAPI inputpane2_TryShow(IInputPane2 *iface, boolean *result) ```suggestion:-0+0 static HRESULT WINAPI inputpane2_TryShow( IInputPane2 *iface, boolean *result ) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58322

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > +/* WinRT Windows.UI Implementation > + * > + * Copyright (C) 2023 Mohamad Al-Jaf Probably should be your name? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58320

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about include/windows.ui.viewmanagement.idl: > + ] > + interface IInputPaneVisibilityEventArgs : IInspectable > + { > + [propget] HRESULT OccludedRect([out, retval] Windows.Foundation.Rect *value); > + [propput] HRESULT EnsuredFocusedElementInView([in] boolean value); > + [propget] HRESULT EnsuredFocusedElementInView([out, retval] boolean *value); > + } > + > + [ > + contract(Windows.Foundation.UniversalApiContract, 1.0), > + exclusiveto(Windows.UI.ViewManagement.InputPane), > + uuid(95f4af3a-ef47-424a-9741-fd2815eba2bd) > + ] > + interface IInputPaneStatics : IInspectable > + { > + HRESULT GetForCurrentView([out, retval] Windows.UI.ViewManagement.InputPane **inputPane); Please don't use camelcase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58318

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > + IsEqualGUID( iid, &IID_IInputPane )) > + { > + *out = &impl->IInputPane_iface; > + } > + else if (IsEqualGUID( iid, &IID_IInputPane2)) > + { > + *out = &impl->IInputPane2_iface; > + } > + > + if (!*out) > + { > + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); > + return E_NOINTERFACE; > + } > + > + IUnknown_AddRef( (IUnknown*)*out ); ```suggestion:-0+0 IUnknown_AddRef( (IUnknown *)*out ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58321

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about include/Makefile.in: > inaddr.h \ > indexsrv.idl \ > initguid.h \ > + inputpaneinteropt.idl \ The file should be named `inputpaneinterop.idl`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58319

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon Jan. 21, 2024

Jan. 21, 2024

Rémi Bernon (@rbernon) commented about include/windows.ui.viewmanagement.idl: > [contract(Windows.Foundation.UniversalApiContract, 1.0)] interface Windows.UI.ViewManagement.IUISettings2; > [contract(Windows.Foundation.UniversalApiContract, 1.0)] interface Windows.UI.ViewManagement.IUISettings3; > } > + > + [ > + static(Windows.UI.ViewManagement.IInputPaneStatics, Windows.Foundation.UniversalApiContract, 1.0), > + contract(Windows.Foundation.UniversalApiContract, 1.0), > + marshaling_behavior(standard) In SDK headers `10.0.20348.0` there's also a: `static(Windows.UI.ViewManagement.IInputPaneStatics2, Windows.Foundation.UniversalApiContract, 8.0)` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58317

1 0

[PATCH v8 0/1] MR4578: include: Add Windows.Storage.Streams.InMemoryRandomAccessStream runtimeclass definition.
by Vijay Kiran Kamuju (＠infyquest) Jan. 21, 2024

Jan. 21, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54963 -- v8: include: Add Windows.Storage.Streams.InMemoryRandomAccessStream runtimeclass definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/4578

4 4