January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/1] MR4578: include: Add Windows.Storage.Streams.InMemoryRandomAccessStream runtimeclass definition.
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

On Tue Dec 5 01:27:16 2023 +0000, Fabian Maurer wrote: > Probably just `activatable(Windows.Foundation.UniversalApiContract, > 1.0)`. But I'm pretty sure you need that activatable if you want it to > be usable later. Still not activatable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4578#note_58307

1 0

[PATCH v4 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

-- v4: winegstreamer: Don't check event for NULL, gstreamer already does that https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

2 2

Re: [PATCH v3 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Rémi Bernon Jan. 20, 2024

Jan. 20, 2024

Fwiw gst_pad_push_event already does NULL check and prints a Glib critical error message if that's the case. That's semantically equivalent to an assert according to the Glib documentation, so IMO we could just get rid of the checks on our side entirely, and do `push_event(gst_event_new...)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4665#note_58301

1 0

Re: [PATCH v7 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

Any news on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3105#note_58299

1 0

[PATCH v2 0/1] MR4667: bcrypt: Initialize variable in all cases (Coverity)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

If both branches are false we would never initialize it. -- v2: bcrypt: Add error handling if neither public nor private key is available (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4667

2 4

[PATCH 0/8] MR3059: Don't redefine typedefs (needed for gcc 4.3)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3059

6 23

[PATCH v4 0/2] MR3061: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v4: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3) wmphoto: Define ansi flag for JXRGlue to avoid typedef redefinitions (gcc 4.3) https://gitlab.winehq.org/wine/wine/-/merge_requests/3061

4 7

[PATCH v13 0/4] MR4852: Add support from AudioPathConfig
by Yuxuan Shui (＠yshui) Jan. 20, 2024

Jan. 20, 2024

-- v13: dmime: Semi-support creating an audio path from config. dmime: IDirectMusicPerformance::CreateAudioPath should fail when config is NULL. dmime: Parse AudioPathConfig https://gitlab.winehq.org/wine/wine/-/merge_requests/4852

3 7

[PATCH 0/3] MR4893: msvcp140: Add _XGetLastError implementation.
by Piotr Caban (＠piotr) Jan. 20, 2024

Jan. 20, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4893

5 5

[PATCH v2 0/4] MR4893: msvcp140: Add _XGetLastError implementation.
by Piotr Caban (＠piotr) Jan. 20, 2024

Jan. 20, 2024

-- v2: msvcp140: Recognize no error case in _Syserror_map. msvcp140/tests: Fix _Syserror_map(0) test failure in newest msvcp140. https://gitlab.winehq.org/wine/wine/-/merge_requests/4893

3 5