November 2024 - Wine-GitLab

[PATCH 0/5] MR6771: dplayx: Send() implementation.
by Anton Baskanov (＠baskanov) Nov. 5, 2024

Nov. 5, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6771

4 7

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 5, 2024

Nov. 5, 2024

On Mon Nov 4 22:04:51 2024 +0000, Alanas wrote: > handling is simpler if toolbar thinks parent wants unicode notifications > `nmhdr->hwndFrom` is not accessed and no overwriting `nmhdr->code` > (tested all `nmhdr->code`s): > - https://bugs.winehq.org/attachment.cgi?id=77361&action=edit > - https://bugs.winehq.org/attachment.cgi?id=77363&action=edit For Unicode notification conversions, you might want to take a look at 76f8ea75 and d7dcfe03. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86593

1 0

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) Nov. 5, 2024

Nov. 5, 2024

You can remove `dlls/` from `dlls/wintypes` in the commit message subjects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86592

1 0

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) Nov. 5, 2024

Nov. 5, 2024

Please keep merge requests small and each commit atomic, ~5 patches or so for an MR would be best. Each MR should ideally have its corresponding tests. That will help with the reviewing. Note that there are CI build failures. You will need to address that as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86591

1 0

[PATCH v8 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 5, 2024

Nov. 5, 2024

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v8: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Chunhao Hung (＠otakuxtom) Nov. 5, 2024

Nov. 5, 2024

This cause wineserver crash after merged, revert those two commit will fix the crash -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86577

1 0

[PATCH v2 0/1] MR6481: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3
by Alistair Leslie-Hughes (＠alesliehughes) Nov. 5, 2024

Nov. 5, 2024

Use the unicode interface by default and return the same value as before this change. There are a few locations, that called W->A. It will return the same value as before for the Ansi version but the unicode one will now report an error. -- v2: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3 https://gitlab.winehq.org/wine/wine/-/merge_requests/6481

3 2

[PATCH 0/1] MR6769: mountmgr.sys: Stub StorageDeviceSeekPenaltyProperty query.
by Paul Gofman (＠gofman) Nov. 4, 2024

Nov. 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6769

2 2

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Joel Holdsworth (＠jhol) Nov. 4, 2024

Nov. 4, 2024

:tada: :tada: :tada: Big step forward for Msys2 support! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86567

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) Nov. 4, 2024

Nov. 4, 2024

On Mon Nov 4 18:51:22 2024 +0000, Alanas wrote: > > In your winehq test, 0xffff0000u seems like a special value. > No, you can replace it with `0u` and get same (except addresses) output > but `foo5.exe` runs very slow. handling is simpler if toolbar thinks parent wants unicode notifications `nmhdr->hwndFrom` is not accessed and no overwriting `nmhdr->code` (tested all `nmhdr->code`s): - https://bugs.winehq.org/attachment.cgi?id=77361&action=edit - https://bugs.winehq.org/attachment.cgi?id=77363&action=edit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86566

1 0