February 2024 - Wine-GitLab

[PATCH v3 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Feb. 7, 2024

Feb. 7, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v3: tests: Remove [require] directives for tests that use int and bool uniforms. tests/shader-runner: Introduce "if" qualifier. tests: Don't ignore SM1 on a non-const-indexing.shader_test test. tests/vkd3d-shader: Set uninitialized uniforms to zero. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

4 7

[PATCH v14 0/8] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) Feb. 7, 2024

Feb. 7, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v14: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 10

[PATCH v13 0/8] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) Feb. 7, 2024

Feb. 7, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v13: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI tracks. dmime: Add stubs for MIDI tracks dmime: Parse MIDI headers. dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

2 10

[PATCH v12 0/7] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) Feb. 7, 2024

Feb. 7, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v12: dmime: Create a band track for MIDI segments. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

[PATCH 0/1] MR5045: wbemprox: Add property 'Caption' to Win32_DiskDrive.
by Louis Lenders (＠xe) Feb. 7, 2024

Feb. 7, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56291 Note: In windows powershell something like "get-wmiobject win32_diskdrive -property caption,model" returns the same string for both, so I copied string for "caption" from "model" See also https://bugs.winehq.org/show_bug.cgi?id=56291#c9 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5045

3 2

[PATCH v3 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns Feb. 7, 2024

Feb. 7, 2024

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- v3: ntdll: loader_init() invoke breakpoint before loading dlls https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

3 5

[PATCH v5 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) Feb. 7, 2024

Feb. 7, 2024

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v5: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Use positive logic on add_*_method_call() functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

3 8

[PATCH 0/5] MR636: vkd3d-shader/fx: Add initial support for writing buffers descriptions.
by Nikolay Sivov (＠nsivov) Feb. 7, 2024

Feb. 7, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/636

3 9

Re: [PATCH v5 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING. - approved
by Rémi Bernon Feb. 7, 2024

Feb. 7, 2024

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

1 0

Re: [PATCH v3 0/1] MR5024: msvcrt: Adjust _gmtime64_s() accepted time limits.
by Piotr Caban (＠piotr) Feb. 7, 2024

Feb. 7, 2024

On Tue Feb 6 18:17:58 2024 +0000, Piotr Caban wrote: > That's a shame, I was hoping that there will be correlation between > maximum values. I'm OK with current patch in this case. Note that most "extreme" differences from UTC time zone are: - +14 hours at Line Islands (Kiribati) - -12 hours in and around Baker Islands I guess that may by the cause of 14 hours range difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5024#note_60424

1 0