February 2024 - Wine-GitLab

Re: [PATCH v5 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING. - approved
by Rémi Bernon Feb. 7, 2024

Feb. 7, 2024

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

1 0

Re: [PATCH v3 0/1] MR5024: msvcrt: Adjust _gmtime64_s() accepted time limits.
by Piotr Caban (＠piotr) Feb. 7, 2024

Feb. 7, 2024

On Tue Feb 6 18:17:58 2024 +0000, Piotr Caban wrote: > That's a shame, I was hoping that there will be correlation between > maximum values. I'm OK with current patch in this case. Note that most "extreme" differences from UTC time zone are: - +14 hours at Line Islands (Kiribati) - -12 hours in and around Baker Islands I guess that may by the cause of 14 hours range difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5024#note_60424

1 0

[PATCH v4 0/4] MR4066: win32u: Skip windows that are not activated even once in activate_other_window().
by Zhiyi Zhang (＠zhiyi) Feb. 7, 2024

Feb. 7, 2024

-- v4: win32u: Don't move an owned window on top of its owner if it's not activated ever. user32/tests: Test the z-order for an owned window that's not activated ever. win32u: Skip windows that are not activated even once in activate_other_window(). user32/tests: Add window activation tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4066

3 7

Re: [PATCH v3 0/1] MR5037: kernelbase: Reduce FIXME to TRACE if params is null.
by Nikola Kuburović Feb. 7, 2024

Feb. 7, 2024

On Wed Feb 7 03:37:47 2024 +0000, Zebediah Figura wrote: > The commits should be squashed together. They should be properly squashed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5037#note_60421

1 0

[PATCH v14 0/4] MR564: vkd3d-shader/ir: Transform clip/cull signature elements into an array.
by Conor McCarthy (＠cmccarthy) Feb. 6, 2024

Feb. 6, 2024

-- v14: tests/d3d12: Test multiple clip distance inputs in test_clip_distance(). tests/d3d12: Use five clip distances for the multiple test in test_clip_distance(). vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

2 4

[PATCH v4 0/2] MR4786: win32u: Query virtual desktop status from the registry.
by Zhiyi Zhang (＠zhiyi) Feb. 6, 2024

Feb. 6, 2024

Checking flags of the thread desktop to determine whether virtual desktop is on is unreliable. For example, CEF applications create their own desktop and so is_virtual_desktop() could incorrectly report that virtual desktop is off. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55810 -- v4: server: inherit wine internal desktop flags when creating desktops. https://gitlab.winehq.org/wine/wine/-/merge_requests/4786

3 5

[PATCH v2 0/2] MR5037: kernelbase: Reduce FIXME to TRACE if params is null.
by Nikola Kuburović Feb. 6, 2024

Feb. 6, 2024

The game I was trying to run (Ravendawn) was polluting the stdout with hundreds of CreateFile2 FIXMEs. The game worked fine, probably because the params pointer was NULL, so any non-implemented extra parameters weren't even used and we just forwarded to CreateFileW. So, a simple if was added to check whether the pointer is null, and if it is, we just call TRACE instead of FIXME since in this case it isn't really necessary. -- v2: kernelbase: Refactor extended parameter logging. https://gitlab.winehq.org/wine/wine/-/merge_requests/5037

4 5

[PATCH 0/2] MR5044: ntdll: Fix some threadpool races.
by Paul Gofman (＠gofman) Feb. 6, 2024

Feb. 6, 2024

That seems to fix some (difficult to reproduce) crashes in EA Desktop / CEF, usually on shutdown but sometimes during starting up. Currently TpSetWait can set (or clear) the event, while waitqueue_thread_proc() gets woken from NtWaitForMultipleObjects by previously set wait object and call the callback as if new set (or cleared) wait object is signaled. The crashes I was reproducing were always happening when RtlDeregisterWaitEx call is racing with waking the wait and calling the callback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

3 3

[PATCH 0/1] MR628: vkd3d-shader/dxil: Initialise the register before calling src_param_init_scalar().
by Conor McCarthy (＠cmccarthy) Feb. 6, 2024

Feb. 6, 2024

Fixes regression in 1f536238a. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/628

3 5

[PATCH v3 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) Feb. 6, 2024

Feb. 6, 2024

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v3: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

3 11