February 2024 - Wine-GitLab

[PATCH v3 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns Feb. 7, 2024

Feb. 7, 2024

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- v3: ntdll: loader_init() invoke breakpoint before loading dlls https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

3 5

[PATCH v5 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) Feb. 7, 2024

Feb. 7, 2024

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v5: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Use positive logic on add_*_method_call() functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

3 8

[PATCH 0/5] MR636: vkd3d-shader/fx: Add initial support for writing buffers descriptions.
by Nikolay Sivov (＠nsivov) Feb. 7, 2024

Feb. 7, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/636

3 9

Re: [PATCH v5 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING. - approved
by Rémi Bernon Feb. 7, 2024

Feb. 7, 2024

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

1 0

Re: [PATCH v3 0/1] MR5024: msvcrt: Adjust _gmtime64_s() accepted time limits.
by Piotr Caban (＠piotr) Feb. 7, 2024

Feb. 7, 2024

On Tue Feb 6 18:17:58 2024 +0000, Piotr Caban wrote: > That's a shame, I was hoping that there will be correlation between > maximum values. I'm OK with current patch in this case. Note that most "extreme" differences from UTC time zone are: - +14 hours at Line Islands (Kiribati) - -12 hours in and around Baker Islands I guess that may by the cause of 14 hours range difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5024#note_60424

1 0

[PATCH v4 0/4] MR4066: win32u: Skip windows that are not activated even once in activate_other_window().
by Zhiyi Zhang (＠zhiyi) Feb. 7, 2024

Feb. 7, 2024

-- v4: win32u: Don't move an owned window on top of its owner if it's not activated ever. user32/tests: Test the z-order for an owned window that's not activated ever. win32u: Skip windows that are not activated even once in activate_other_window(). user32/tests: Add window activation tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4066

3 7

Re: [PATCH v3 0/1] MR5037: kernelbase: Reduce FIXME to TRACE if params is null.
by Nikola Kuburović Feb. 7, 2024

Feb. 7, 2024

On Wed Feb 7 03:37:47 2024 +0000, Zebediah Figura wrote: > The commits should be squashed together. They should be properly squashed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5037#note_60421

1 0

[PATCH v14 0/4] MR564: vkd3d-shader/ir: Transform clip/cull signature elements into an array.
by Conor McCarthy (＠cmccarthy) Feb. 7, 2024

Feb. 7, 2024

-- v14: tests/d3d12: Test multiple clip distance inputs in test_clip_distance(). tests/d3d12: Use five clip distances for the multiple test in test_clip_distance(). vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

2 4

[PATCH v4 0/2] MR4786: win32u: Query virtual desktop status from the registry.
by Zhiyi Zhang (＠zhiyi) Feb. 7, 2024

Feb. 7, 2024

Checking flags of the thread desktop to determine whether virtual desktop is on is unreliable. For example, CEF applications create their own desktop and so is_virtual_desktop() could incorrectly report that virtual desktop is off. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55810 -- v4: server: inherit wine internal desktop flags when creating desktops. https://gitlab.winehq.org/wine/wine/-/merge_requests/4786

3 5

[PATCH v2 0/2] MR5037: kernelbase: Reduce FIXME to TRACE if params is null.
by Nikola Kuburović Feb. 7, 2024

Feb. 7, 2024

The game I was trying to run (Ravendawn) was polluting the stdout with hundreds of CreateFile2 FIXMEs. The game worked fine, probably because the params pointer was NULL, so any non-implemented extra parameters weren't even used and we just forwarded to CreateFileW. So, a simple if was added to check whether the pointer is null, and if it is, we just call TRACE instead of FIXME since in this case it isn't really necessary. -- v2: kernelbase: Refactor extended parameter logging. https://gitlab.winehq.org/wine/wine/-/merge_requests/5037

4 5