February 2024 - Wine-GitLab

Re: [PATCH v7 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) Feb. 6, 2024

Feb. 6, 2024

Any feedback regarding this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3105#note_60351

1 0

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) Feb. 6, 2024

Feb. 6, 2024

Any news on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_60349

1 0

[PATCH v2 0/2] MR5025: explorer: Don't pop start menu on "minimize all windows" systray command.
by Paul Gofman (＠gofman) Feb. 6, 2024

Feb. 6, 2024

Fixes "True Reporter. Mystery of Mistwood" broken startup from launcher when the launcher wants to minimize all windows (which is probably not strictly necessary) but we instead pop Start menu. -- v2: explorer: Don't pop start menu on "undo minimize all windows" systray command. explorer: Don't pop start menu on "minimize all windows" systray command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5025

4 5

[PATCH v11 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) Feb. 6, 2024

Feb. 6, 2024

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v11: mf/tests: Test IMFMediaSession::Start(). mf: Support seeking while a session is started. mf/tests: Add a create_test_topology() helper. mf: Add a session_flush_nodes() helper. mf: Make session_get_node_object() more robust. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

3 8

[PATCH 0/1] MR5015: d2d1: Compile vertex shaders with D3DCompile().
by Giovanni Mascellani (＠giomasce) Feb. 6, 2024

Feb. 6, 2024

Unfortunately the pixel shader cannot be compiled yet because `Buffer` is not yet supported. If https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569 is accepted in vkd3d 1.11, next month we'll be able to get rid of the binary pixel shader too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5015

3 2

[PATCH 0/1] MR5023: quartz: Release critical section before IVideoWindow_put_Visible
by CKolle (＠CKolle) Feb. 6, 2024

Feb. 6, 2024

The IVideoWindow_put_Visible runs the NtUserShowWindow which may trigger the VideoWindow_NotifyOwnerMessage with a WM_PAINT message and afterwards try to send a WM_ERASEBKND. This will cause the VideoWindow_NotifyOwnerMessage to be stuck waiting on the lock. This causes a deadlock because the IVideoWindow_put_Visible is never able to return, as it is waiting for the WM_ERASEBKND message to go through in the send_erase function, which can only go through once the WM_PAINT has returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5023

3 4

[PATCH 0/1] MR5038: dmusic: Fix loading wave data from soundfont.
by Yuxuan Shui (＠yshui) Feb. 6, 2024

Feb. 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5038

4 3

[PATCH v3 0/3] MR5035: Change SetLastError to RestoreLastError if appropriate
by Alfred Agrell (＠Alcaro) Feb. 6, 2024

Feb. 6, 2024

Theoretically, this allows debuggers to tell them apart. https://devblogs.microsoft.com/oldnewthing/20110429-00/?p=10803 But in practice, this is more about cleanliness than anything else; I'm not aware of anyone running SetLastError-aware debuggers in Wine. Feel free to reject if this is a waste of time. The changeable SetLastError calls were found by this script: ```python #!/usr/bin/env python3 import os import re for (dirpath, dirnames, filenames) in os.walk("."): for fn in filenames: if not fn.endswith(".c") and not fn.endswith(".h"): continue text = open(dirpath+"/"+fn,"rt").read() text = text.replace("RtlSetLastWin32Error","SetLastError") text = text.replace("RtlGetLastWin32Error","GetLastError") if "SetLastError" not in text: continue varname = None for line in text.split("\n"): if "GetLastError" in line: if m := re.search(r"([A-Za-z0-9_]+) *= *GetLastError", line): prevline = line varname = m[1] if line == "}": varname = None if varname is not None and "SetLastError" in line: if m := re.search(r"SetLastError\( *([A-Za-z0-9_]+) *\)", line): if m[1] == varname: print(dirpath+"/"+fn, prevline, line) ``` The script also flags https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/mpr/wnet.c#L2811, which is half set and half restore; I chose to left it unchanged. Idea from https://gitlab.winehq.org/wine/wine/-/merge_requests/5020/diffs#6c845445f68… -- v3: win32u: Use RtlRestoreLastWin32Error instead of RtlSetLastWin32Error if appropriate everywhere: Change SetLastError to RestoreLastError if appropriate https://gitlab.winehq.org/wine/wine/-/merge_requests/5035

3 5

[PATCH v4 0/10] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) Feb. 6, 2024

Feb. 6, 2024

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v4: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). kernelbase: Do not canonicalize the relative part in UrlCombine(). kernelbase: Do not use isalnum() with Unicode characters. https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 13

[PATCH v5 0/4] MR4761: ntdll: Implement NtContinueEx()
by Dāvis Mosāns Feb. 6, 2024

Feb. 6, 2024

This MR implements `NtContinueEx(PCONTEXT, PCONTINUE_OPTIONS)` which was added in Windows 10 20H1. Also added basic test reusing existing `test_continue()` (included from !4720) League of Legends game hooks `NtContinue()` and `NtContinueEx()` by putting `jmp` instruction in front of it. Note that LoL doesn't actually use `NtContinueEx()` itself and game will work fine without it but if game doesn't find `NtContinueEx()` it will permanently ban your account due to detecting "scripting program" -- v5: ntdll/tests: Implement APC test for NtContinue() ntdll/tests: Add basic test for NtContinueEx() ntdll: Implement NtContinueEx() ntdll/tests: Unify APC test functions https://gitlab.winehq.org/wine/wine/-/merge_requests/4761

1 5