March 2024 - Wine-GitLab - list.winehq.org

[PATCH v3 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) March 6, 2024

March 6, 2024

This also bumps the minimum supported version of macOS to 10.12 to unconditionally assume the ulock syscalls are present. As discussed with @Gcenx this shouldn't be an issue, as the current minimum support version of 10.8 does not work anyways at the moment with only 10.10+ being useable and even then virtually no-one using wine on versions < 10.12 (and also being unsupported by the prebuilt binaries). Bumping to 10.12 would also have the side-benefit of allowing some cleanup of deprecated functions or legacy codepaths (like `mach_continuous_time` vs `mach_absolute_time` and probably much more). In my testing ulock futexes are about 2x faster for synchronization than kevents. Using the syscall wrappers here should provide protection against changing syscall numbers, and given that ulock is also directly used by libc++, the probability of an incompatible API change here is basically zero imo. By default ulock is also process-private, similar to the current linux implementation, cross-process synchronization would require darwin 19+ (macOS 10.15+) with `UL_COMPARE_AND_WAIT_SHARED`. The diff is a bit bigger than it actually is in effect, since https://gitlab.winehq.org/mzent/wine/-/commit/28a8a991c165f0d37dbf78ca3cdee… is only moving some code around and not actually changing anything. -- v3: ntdll: Implement futex_wait() and futex_wake_one() on macOS. ntdll: Simplify futex interface from futex_wake() to futex_wake_one(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5237

2 6

[PATCH 0/2] MR5243: winex11: Listen on XInput2 touch events and send WM_POINTER messages.
by Rémi Bernon March 6, 2024

March 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5243

2 3

[PATCH 0/1] MR5245: server: Stop waiting on LL-hooks for non-injected input.
by Rémi Bernon March 6, 2024

March 6, 2024

Tests show that injected input indeed wait on LL-hooks to be processed. However real hardware input isn't normally sent by the processes themselves like Wine does, and it is unnecessary to wait for the LL-hooks to be processed. The applications threads should instead return from the ProcessEvent call when input is received, and process their hooks later as needed, or do some other tasks application might expect them to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5245

1 1

[PATCH 0/3] MR5244: server: Implement finer pointer messages behavior.
by Rémi Bernon March 6, 2024

March 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5244

1 3

[PATCH v7 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) March 6, 2024

March 6, 2024

-- v7: rtworkq: Release cancelled work items. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

3 6

[PATCH v6 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) March 6, 2024

March 6, 2024

-- v6: rtworkq: Release cancelled work items. mfplat: tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

3 5

[PATCH 0/1] MR5242: cmd/tests: Add tests for calling special excuteable files.
by Haidong Yu (＠yhd986) March 6, 2024

March 6, 2024

Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5242

3 2

Re: [PATCH v2 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running.
by Yuxuan Shui (＠yshui) March 6, 2024

March 6, 2024

@nsivov !4243 is not complicated if you weren't so dismissive and made any effort to try and understand it. I was trying so hard to explain it to you too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158#note_63634

1 0

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) March 6, 2024

March 6, 2024

@nsivov since you have approved !5158, do you understand why there is a race that needs to be fixed now? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_63632

1 0

[PATCH 0/4] MR5241: shell32: Reimplement much of IDataObject.
by Zebediah Figura (＠zfigura) March 6, 2024

March 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5241

3 5