March 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/4] MR5216: msi: Fix costing calculations a bit, and avoid overflow.
by Zebediah Figura (＠zfigura) March 4, 2024

March 4, 2024

This work is based on Wine-Staging patch "msi-msi_vcl_get_cost" by Mark Jansen. That patch attempts to avoid overflow, although not particularly well, since the damage would already have been done by calculate_file_cost(). This patch series addresses the issue in both places. The Wine-Staging patch seems to have originally been written in an attempt to address a bug visible with (at least) some Microsoft Office and LibreOffice installers where file costs would render incorrectly. That bug is recorded as ReactOS bug 12229 [1], which report includes both the patch to vcl_get_cost(), and the patch fixing the actual bug, which did eventually made it upstream as b53957df2a73ae51ca6ebc1e88bb9c4ed8b8d274. [1] https://jira.reactos.org/browse/CORE-12229 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5216

4 9

[PATCH v2 0/7] MR5215: shell32: shell32: Implement Paste in the item menu.
by Zebediah Figura (＠zfigura) March 4, 2024

March 4, 2024

-- v2: shell32: Implement Paste in the item menu. shell32: Respect the parent PIDL when pasting from CFSTR_SHELLIDLIST. shell32: Reimplement pasting from CF_DROP directly. shell32: Add a get_data_format() helper. shell32: Move DoPaste() up. shell32: Remove useless and commented out code. shell32/tests: Add tests for context menu copy/paste. https://gitlab.winehq.org/wine/wine/-/merge_requests/5215

2 8

[PATCH v2 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) March 4, 2024

March 4, 2024

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v2: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 3

[PATCH 0/2] MR688: tests/shader_runner: Set the SPIR-V feature flags based on the runner caps.
by Henri Verbeet (＠hverbeet) March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/688

3 4

[PATCH 0/1] MR687: vkd3d-compiler: Compile SPIR-V shaders with the int64 and float64 features.
by Henri Verbeet (＠hverbeet) March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/687

3 3

[PATCH 0/1] MR689: vkd3d-shader: Add documentation for the INT64 and FLOAT64 feature flags.
by Henri Verbeet (＠hverbeet) March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/689

3 3

[PATCH v8 0/6] MR553: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) March 4, 2024

March 4, 2024

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v8: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 7

[PATCH v7 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) March 4, 2024

March 4, 2024

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v7: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. vkd3d-shader/d3d-asm: Refactor dumping a write mask to a dedicated function. vkd3d-shader/d3d-asm: Describe the ASM dialect with a bunch of flags instead of a plain enum. vkd3d-shader/d3d-asm: Do not make a copy of the buffer before returning it. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 6

[PATCH v3 0/3] MR582: vkd3d-dxbc: Add options to fix a DXBC shader checksum.
by Giovanni Mascellani (＠giomasce) March 4, 2024

March 4, 2024

-- v3: vkd3d-dxbc: Add an option to re-emit the shader with the correct checksum. vkd3d-dxbc: Add an option to ignore checksum. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/582

2 4

[PATCH v4 0/4] MR5161: d3drm: Implement Update and related functions
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

Regarding dirty rectangles:<br> Documentation for `ForceUpdate` states that "The system might update any region that is larger than the specified rectangle, including possibly the entire window". While native seems to use a sort of dirty-rectangle approach, for this MR, I am simply dirtying the entire surface. If someday someone did want to more-closely match the behavior of native, much can be learned from the rectangles passed to the update callbacks. -- v4: d3drm: Add support for device update callbacks. d3drm: Blit render target to primary surface on device update. d3drm: Implement parameter validation for viewport force update. d3drm/tests: Add tests for Direct3DRMDevice Update https://gitlab.winehq.org/wine/wine/-/merge_requests/5161

2 5