March 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR5146: d3dcompiler: Enable semantic naming mapping in compatibility mode.
by Nikolay Sivov (＠nsivov) March 4, 2024

March 4, 2024

This was implemented in vkd3d 1.10. Another known feature that has to be enabled with compatibility flag is d3d9 style sampling functions. We currently don't do that, making them supported unconditionally. -- v2: d3dcompiler: Enable semantic names mapping in compatibility mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5146

3 2

[PATCH 0/1] MR5222: kernelbase: Allow WriteProcessMemory to succeed on PAGE_EXECUTE_READ.
by Marc-Aurel Zent (＠mzent) March 4, 2024

March 4, 2024

More details here: https://devblogs.microsoft.com/oldnewthing/20181206-00/?p=100415 However it does not mention that `PAGE_NOACCESS` and `PAGE_READONLY` still result in an error on Windows, which is properly implemented in this MR. Only `WriteProcessMemory` offers this "service", `NtWriteVirtualMemory` will fail on non-writeable and executable regions (and already does so, except for the the mach server backend, which needs https://gitlab.winehq.org/wine/wine/-/merge_requests/4826 to also behave correctly here). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5222

3 4

[PATCH 0/2] MR5209: sapi: Implement more get/put functions for ISpeechVoice.
by Shaun Ren (＠shaunren) March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5209

3 3

Re: [PATCH v2 0/1] MR685: vkd3d-shader/hlsl: Write the SFI0 section and "REQUIRES_ROVS" flag when ROVs are used. - approved
by Henri Verbeet (＠hverbeet) March 4, 2024

March 4, 2024

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/685

1 0

Re: [PATCH v2 0/1] MR685: vkd3d-shader/hlsl: Write the SFI0 section and "REQUIRES_ROVS" flag when ROVs are used.
by Henri Verbeet (＠hverbeet) March 4, 2024

March 4, 2024

> I'd rather accumulate flags while compiling the shader rather than doing another pass at the end. Not a terribly strong opinion, though. In principle I'd be inclined to agree, but this approach seems appropriate this close to the release. Ultimately the tpf writer should get this from the vsir_program, of course. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/685#note_63362

1 0

[PATCH 0/1] MR5223: netprofm/tests: Mark a test result as broken on Windows 11.
by Hans Leidekker (＠hans) March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5223

2 1

[PATCH v3 0/3] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) March 4, 2024

March 4, 2024

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v3: server: Simplify mach write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. server: Use mach_vm_read_overwrite in read_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 4

[PATCH 0/1] MR5218: mfreadwrite/reader: Adjust min_buffer_size to be 1s of audio data.
by Rémi Bernon March 4, 2024

March 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5218

3 3

[PATCH 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running.
by Zhiyi Zhang (＠zhiyi) March 4, 2024

March 4, 2024

Patch 2 fixes a race condition in theory. I haven't found it affecting any real-world applications. These two bugs are caused by race conditions. I don't think adding tests could demonstrate them reliably. This MR can probably fix the race condition mentioned at https://gitlab.winehq.org/wine/wine/-/merge_requests/4243 patch 3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158

3 4

Re: [PATCH v2 0/1] MR685: vkd3d-shader/hlsl: Write the SFI0 section and "REQUIRES_ROVS" flag when ROVs are used.
by Giovanni Mascellani (＠giomasce) March 4, 2024

March 4, 2024

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c: > > +static void write_sm4_sfi0(struct hlsl_ctx *ctx, struct dxbc_writer *dxbc) > +{ > + struct extern_resource *extern_resources; > + unsigned int extern_resources_count; > + uint64_t *flags; > + > + flags = vkd3d_calloc(1, sizeof(*flags)); > + > + extern_resources = sm4_get_extern_resources(ctx, &extern_resources_count); > + for (unsigned int i = 0; i < extern_resources_count; ++i) > + { > + if (extern_resources[i].data_type->e.resource.rasteriser_ordered) > + *flags |= VKD3D_SM4_REQUIRES_ROVS; > + } > + sm4_free_extern_resources(extern_resources, extern_resources_count); I'd rather accumulate flags while compiling the shader rather than doing another pass at the end. Not a terribly strong opinion, though. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/685#note_63346

1 0