March 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR5218: mfreadwrite/reader: Adjust min_buffer_size to be 1s of audio data. - approved
by Alexandre Julliard (＠julliard) March 4, 2024

March 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5218

1 0

Re: [PATCH v2 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running. - approved
by Alexandre Julliard (＠julliard) March 4, 2024

March 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158

1 0

Re: [PATCH v3 0/1] MR5208: winebus.sys: Only attempt to open joysticks and gamepads in the IOHID backend. - approved
by Alexandre Julliard (＠julliard) March 4, 2024

March 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5208

1 0

Re: [PATCH v2 0/4] MR5216: msi: Fix costing calculations a bit, and avoid overflow. - approved
by Alexandre Julliard (＠julliard) March 4, 2024

March 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5216

1 0

[PATCH v6 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

Basically, this is the tests from https://gitlab.winehq.org/wine/wine/-/merge_requests/3420 with fixes applied where they originate, rather than later in the series. -- v6: ddraw/tests: Test Pick() and GetPickRecords(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3422

3 2

[PATCH v5 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

Basically, this is the tests from https://gitlab.winehq.org/wine/wine/-/merge_requests/3420 with fixes applied where they originate, rather than later in the series. -- v5: ddraw/tests: Test Pick() and GetPickRecords(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3422

3 2

Re: [PATCH v4 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

On Mon Mar 4 19:03:27 2024 +0000, Stefan Dösinger wrote: > What does clipped mean here? Outside of the 0.0;1.0 depth range? > In the TLVERTEX case you get depth values -0.5, 6.5 and -3.0, suggesting > that the near and far clip planes don't matter. If I understand this > test here right they do matter for LVERTEX. That is consistent with > later d3d versions where Z clipping is essentially disabled when drawing > pretransformed geometry with the right settings. > Another way to look at this is that Z clipping is done by > D3DPROCESSVERTICES_TRANSFORM not the draw op (D3DOP_TRIANGLE). Yes, depth-clipped. If I'm understanding your last statement properly, it doesn't seem right. Two triangles could share one or two vertices and still be clipped independently. Further, several of the quads in this test have all vertices outside of [0,1] depth range, yet the portions passing through that depth range do result in successful picks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3422#note_63433

1 0

Re: [PATCH v4 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

On Mon Mar 4 19:03:26 2024 +0000, Stefan Dösinger wrote: > I would expect it to write 3 pick records if the input size in > record_count is larger than the number retrieved. I.e., if you set > record_count = 4 and make the array large enough it should write 3 and > leave the 4th untouched. That's the usual pattern for getters like this > at least. I checked this, and you are correct. I will improve the test to cover this as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3422#note_63430

1 0

[PATCH v5 0/4] MR5161: d3drm: Implement Update and related functions
by Jeffrey Smith (＠whydoubt) March 4, 2024

March 4, 2024

Regarding dirty rectangles:<br> Documentation for `ForceUpdate` states that "The system might update any region that is larger than the specified rectangle, including possibly the entire window". While native seems to use a sort of dirty-rectangle approach, for this MR, I am simply dirtying the entire surface. If someday someone did want to more-closely match the behavior of native, much can be learned from the rectangles passed to the update callbacks. -- v5: d3drm: Add support for device update callbacks. d3drm: Blit render target to primary surface on device update. d3drm: Implement parameter validation for viewport force update. d3drm/tests: Add tests for Direct3DRMDevice Update https://gitlab.winehq.org/wine/wine/-/merge_requests/5161

2 4

[PATCH v2 0/1] MR5083: server: Try to retrieve the unix name on handles created from file descriptors.
by Gabriel Ivăncescu March 4, 2024

March 4, 2024

Useful with unix integration of redirected standard handles. Simple testcase: ```c #include <windows.h> #include <stdio.h> int main(int argc, char **argv) { char buf[4096] = {0}; FILE_NAME_INFO *name_info = (FILE_NAME_INFO*)buf; if (!GetFileInformationByHandleEx(GetStdHandle(STD_OUTPUT_HANDLE), FileNameInfo, name_info, sizeof(buf))) { fprintf(stderr, "GetFileInformationByHandleEx failed %08lx\n", GetLastError()); return 1; } WriteFile(GetStdHandle(STD_ERROR_HANDLE), name_info->FileName, name_info->FileNameLength, NULL, NULL); return 0; } ``` On Windows: ``` test.exe > C:\Temp\test.txt ``` Output: ``` \Temp\test.txt ``` On wine: ``` wine test.exe > /tmp/wine/testprefix/drive_c/Temp/test.txt ``` Upstream output: ``` GetFileInformationByHandleEx failed 00000006 ``` With this MR: ``` \Temp\test.txt ``` -- v2: server: Try to retrieve the unix name on handles created from file https://gitlab.winehq.org/wine/wine/-/merge_requests/5083

2 5