March 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR5334: msxml6/tests: Add some tests for MXWriter60.
by Nikolay Sivov (＠nsivov) March 17, 2024

March 17, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5334

3 2

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) March 16, 2024

March 16, 2024

On Sat Mar 16 23:31:12 2024 +0000, Nikolay Sivov wrote: > So, no bigger plan other than fixing up idls basically? I currently don't have one. Through wine-staging patches for FreeThreadedXMLHTTP60 interface rely on this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65058

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) March 16, 2024

March 16, 2024

On Sat Mar 16 23:31:12 2024 +0000, Alistair Leslie-Hughes wrote: > First brings the headers inline with the SDK. > Second allows you to build against the wine headers without getting a > link time GUID duplicates. So, no bigger plan other than fixing up idls basically? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65057

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) March 16, 2024

March 16, 2024

First brings the headers inline with the SDK. Second allows you to build against the wine headers without getting a link time GUID duplicates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65056

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) March 16, 2024

March 16, 2024

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + *RtlSubAuthoritySid(sidwin7, 1) = DOMAIN_ALIAS_RID_ADMINS; > + > + sid2 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(1)); > + RtlInitializeSid(sid2, &auth, 1); > + *RtlSubAuthoritySid(sid2, 0) = SECURITY_LOCAL_SYSTEM_RID; > + > + /* SECURITY_BUILTIN_DOMAIN_RID */ > + status = RtlGetAce(acl, 0, (void**)&ace); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + > + ok(ace->Header.AceType == ACCESS_ALLOWED_ACE_TYPE, "got %#x\n", ace->Header.AceType); > + ok(ace->Header.AceFlags == 0, "got %#x\n", ace->Header.AceFlags); > + ok(ace->Mask == STANDARD_RIGHTS_ALL, "got %#lx\n", ace->Mask); > + > + ret = RtlEqualSid(sid1, (PSID)&ace->SidStart) || RtlEqualSid(sidwin7, (PSID)&ace->SidStart); > + ok(ret, "SID not equal\n"); Maybe it'd be a bit simpler to test the SID elements individually rather than constructing a SID and using RtlEqualSid()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65055

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) March 16, 2024

March 16, 2024

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + PSID group = NULL, owner = NULL; > + BOOLEAN isdefault, present; > + PACL acl = NULL; > + PACCESS_ALLOWED_ACE ace; > + SID_IDENTIFIER_AUTHORITY auth = { SECURITY_NULL_SID_AUTHORITY }; > + SID_IDENTIFIER_AUTHORITY authwine7 = { SECURITY_NT_AUTHORITY }; > + PSID sid1, sid2, sidwin7; > + BOOL ret; > + > + status = FltBuildDefaultSecurityDescriptor(&sd, STANDARD_RIGHTS_ALL); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + if (status != STATUS_SUCCESS) > + { > + win_skip("Skipping FltBuildDefaultSecurityDescriptor tests\n"); > + return; > + } Do we need this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65053

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) March 16, 2024

March 16, 2024

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + } > + ok(sd != NULL, "Failed to return descriptor\n"); > + > + status = RtlGetGroupSecurityDescriptor(sd, &group, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(group == NULL, "group isn't NULL\n"); > + > + status = RtlGetOwnerSecurityDescriptor(sd, &owner, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(owner == NULL, "owner isn't NULL\n"); > + > + status = RtlGetDaclSecurityDescriptor(sd, &present, &acl, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(acl != NULL, "acl is NULL\n"); > + ok(acl->AceCount == 2, "got %d\n", acl->AceCount); > + Should we test "isdefault" here as well? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65054

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) March 16, 2024

March 16, 2024

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > + goto done; > + RtlInitializeSid(sid, &auth, 2); > + sid->SubAuthority[1] = DOMAIN_GROUP_RID_ADMINS; > + sid->SubAuthority[0] = SECURITY_BUILTIN_DOMAIN_RID; > + > + sid_len = RtlLengthRequiredSid(1); > + sid_system = ExAllocatePool(PagedPool, sid_len); > + if (!sid_system) > + goto done; > + RtlInitializeSid(sid_system, &auth, 1); > + sid_system->SubAuthority[0] = SECURITY_LOCAL_SYSTEM_RID; > + > + sid_len = SECURITY_DESCRIPTOR_MIN_LENGTH + sizeof(ACL) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid_system); > + Maybe rename "sid_len" to "len" if you're going to use it for other things? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65052

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) March 16, 2024

March 16, 2024

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > > return func; > } > + > +NTSTATUS WINAPI FltBuildDefaultSecurityDescriptor(PSECURITY_DESCRIPTOR *descriptor, ACCESS_MASK access) > +{ > + PACL dacl; > + NTSTATUS ret = STATUS_INSUFFICIENT_RESOURCES; This initialization isn't doing anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65051

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) March 16, 2024

March 16, 2024

@alesliehughes could you remind me what this was going to fix? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65050

1 0