March 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) March 16, 2024

March 16, 2024

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- v2: winemac.drv: Give dead keys a friendly name in GetKeyNameText. winemac.drv: Add additional French symbol vkeys. winemac.drv: Add additional German symbol vkeys. winemac.drv: Resolve symbol vkeys first without modifiers. winemac.drv: Use UCCompareText in char_matches_string. winemac.drv: Uppercase single keys in GetKeyNameText. winemac.drv: Do not append " dead" to dead keycodes in GetKeyNameText. winemac.drv: Handle length of dead keycodes in ToUnicodeEx correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

3 12

[PATCH 0/1] MR5330: server: Check for DELETE access in NtMakeTemporaryObject().
by Jinoh Kang (＠iamahuman) March 16, 2024

March 16, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5330

3 2

[PATCH 0/4] MR5329: ddraw: Support multiple devices per ddraw object.
by Paul Gofman (＠gofman) March 16, 2024

March 16, 2024

Fixes Sim City 3000 Building Architect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5329

3 5

Re: [PATCH v2 0/1] MR5327: user32/tests: Add another missing message for TrackPopupMenu. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5327

1 0

Re: [PATCH v2 0/1] MR5316: server: Ignore some ICMP-originated socket errors for connectionless sockets. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5316

1 0

Re: [PATCH v2 0/1] MR5325: wshom/network: Implement UserDomain property. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5325

1 0

Re: [PATCH v3 0/2] MR5323: win32u: Key auto-repeat improvements. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5323

1 0

Re: [PATCH v2 0/4] MR5321: Minidump slowdowns (Part III) - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5321

1 0

Re: [PATCH v4 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5294

1 0

Re: [PATCH v2 0/1] MR5320: ntdll/tests: Fix a test failure. - approved
by Alexandre Julliard (＠julliard) March 15, 2024

March 15, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5320

1 0