March 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Jan Sikorski (＠jsikorski) March 12, 2024

March 12, 2024

Sorry for the long silence. A couple of nits above, but generally that looks fine to me. My understanding is that we could in principle have a client that calls Microsoft's d3d9on12.dll instead of returning our d3d9, is that right? The games just go through `Direct3DCreate9On12` but then only use the D3D9 interface? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4915#note_64358

1 0

Re: [PATCH v5 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Jan Sikorski (＠jsikorski) March 12, 2024

March 12, 2024

Jan Sikorski (@jsikorski) commented about dlls/d3d9/d3d9on12.c: > + d3d9on12_ReturnUnderlyingResource, > +}; > + > +BOOL d3d9on12_init( struct d3d9on12 **d3d9on12, D3D9ON12_ARGS *override_list, UINT override_entries ) > +{ > + struct d3d9on12 *object; > + > + if (!override_list || !override_list->Enable9On12 || !override_entries) > + { > + *d3d9on12 = NULL; > + return TRUE; > + } > + > + if (!(object = calloc( 1, sizeof(*object) ))) > + return FALSE; > + if (!(object->override_list = calloc( 1, sizeof(D3D9ON12_ARGS) ))) That's a bit odd: if we only care about the first entry, why not just store it in a static member? Or if we don't care about it, don't store it at all? To me, use of `calloc` here indicates an intention that I'm missing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4915#note_64355

1 0

Re: [PATCH v5 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Jan Sikorski (＠jsikorski) March 12, 2024

March 12, 2024

Jan Sikorski (@jsikorski) commented about dlls/d3d9/d3d9on12.c: > +{ > + /* IUnknown */ > + d3d9on12_QueryInterface, > + d3d9on12_AddRef, > + d3d9on12_Release, > + /* IDirect3DDevice9On12 */ > + d3d9on12_GetD3D12Device, > + d3d9on12_UnwrapUnderlyingResource, > + d3d9on12_ReturnUnderlyingResource, > +}; > + > +BOOL d3d9on12_init( struct d3d9on12 **d3d9on12, D3D9ON12_ARGS *override_list, UINT override_entries ) > +{ > + struct d3d9on12 *object; > + > + if (!override_list || !override_list->Enable9On12 || !override_entries) Do we want to dereference the list before checking `override_entries`? I see that was changed previously, I'm not sure why, to me the current version is confusing and I don't see a test that justifies it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4915#note_64353

1 0

[PATCH 0/1] MR5287: d2d1: Make some strings const.
by Dmitry Timoshkov (＠dmitry) March 12, 2024

March 12, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56379 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5287

3 2

[PATCH 0/1] MR5286: kerberos: Allocate memory for the returned token if requested.
by Dmitry Timoshkov (＠dmitry) March 12, 2024

March 12, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56400 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5286

3 3

Re: [PATCH v6 0/5] MR4971: comdlg32: Fix item data in resolutions combobox. - approved
by Huw Davies (＠huw) March 12, 2024

March 12, 2024

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4971

1 0

[PATCH v3 0/13] MR707: vkd3d-shader/dxil: TGSM part 2.
by Conor McCarthy (＠cmccarthy) March 12, 2024

March 12, 2024

Goes atop !681. The last 8 commits belong here. -- v3: vkd3d-shader/spirv: Emit a warning if atomic RMW flags are unhandled. vkd3d-shader/dxil: Implement the DXIL ATOMICRMW instruction. vkd3d-shader/dxil: Implement DX instructions ThreadId, GroupId, ThreadIdInGroup and FlattenedThreadIdInGroup. tests/shader-runner: Add TGSM tests. vkd3d-shader/dxil: Emit an error if a constant code is unhandled. vkd3d-shader/spirv: Support 64-bit register info component type in spirv_compiler_emit_load_reg(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/707

2 14

[PATCH v2 0/12] MR707: vkd3d-shader/dxil: TGSM part 2.
by Conor McCarthy (＠cmccarthy) March 12, 2024

March 12, 2024

Goes atop !681. The last 7 commits belong here. -- v2: vkd3d-shader/spirv: Emit a warning if atomic RMW flags are unhandled. vkd3d-shader/dxil: Implement the DXIL ATOMICRMW instruction. vkd3d-shader/dxil: Implement DX instructions ThreadId, GroupId, ThreadIdInGroup and FlattenedThreadIdInGroup. tests/shader-runner: Add TGSM tests. vkd3d-shader/dxil: Emit an error if a constant code is unhandled. vkd3d-shader/spirv: Do not assert if a TGSM store data register is not UINT. vkd3d-shader/spirv: Do not assert if a TGSM load dst register is not UINT. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/707

2 12

[PATCH 0/12] MR707: vkd3d-shader/dxil: TGSM part 2.
by Conor McCarthy (＠cmccarthy) March 12, 2024

March 12, 2024

Goes atop !681. The last 7 commits belong here. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/707

2 12

[PATCH v3 0/3] MR698: vkd3d-shader/ir: Introduce a better CFG structurizer, part 4.
by Giovanni Mascellani (＠giomasce) March 12, 2024

March 12, 2024

~~This applies on top of !672, the last three commits belong here.~~ Here we compute additional "synthetic" loops that will be used to implement non-trivial forward edges using (possibly conditional) `break` instructions. -- v3: vkd3d-shader/ir: Sort loop intervals. vkd3d-shader/ir: Generate synthetic intervals for forward edges. vkd3d-shader/ir: Compute loop as intervals of the block order. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/698

3 9