March 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/4] MR679: vkd3d-shader: Refactor common code between vkd3d_shader_compile() and vkd3d_shader_scan(). - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/679

1 0

Re: [PATCH v10 0/4] MR672: vkd3d-shader/ir: Introduce a better CFG structurizer, part 3. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/672

1 0

Re: [PATCH v5 0/1] MR666: vkd3d-shader/hlsl: Allow modifiers on buffer declarations. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/666

1 0

Re: [PATCH v6 0/2] MR661: tests: Introduce custom test driver. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/661

1 0

Re: [PATCH v11 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

1 0

Re: [PATCH v2 0/1] MR5265: server: Remove desktop from their winstation list before looking for another input desktop. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5265

1 0

Re: [PATCH v2 0/2] MR5263: win32u: Only send mouse input in ReleaseCapture() when a window is captured. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5263

1 0

Re: [PATCH v4 0/4] MR5228: Administrator tokens, part 2: Create Wine processes with a limited token. - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5228

1 0

Re: [PATCH v3 0/1] MR5254: msvcrt: Handle wide specifiers option in __stdio_common_vfscanf() - approved
by Alexandre Julliard (＠julliard) March 8, 2024

March 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5254

1 0

Re: [PATCH v7 0/1] MR3422: ddraw tests for Pick and GetPickRecords
by Stefan Dösinger March 8, 2024

March 8, 2024

On Fri Mar 8 17:52:04 2024 +0000, Stefan Dösinger wrote: > The test passes on the HW device of my way newer Radeon Polaris card on > Windows 11. As of now I am unsuccessful in getting my Radeon 9000 from > 2002 to produce any pick results. > On a quick test run it seems Lego Island is happy with setting *count = > 0 in IDirect3DDevice::GetPickRecords. That prevents it from trying to > essentially malloc a random amount of memory. But I am not entirely > certain, the menu of this game is confusing. I was (intellectually) > unable to start a game even on Windows... > I am downloading FIGHTING to see if it works on my old machine and to > see if it uses a HW device or just the RGB device. Judging by the > screenshots it might just software render. Ok, I got pick results out of my Radeon 9000. Let's just say, it is a bit ... picky. What I had to do was call BeginScene(); Execute(); EndScene(); before calling Pick. But don't do it from the same stack frame, or it fails. And don't think of having some zeroes on the stack. (Same stack frame: If I move the Execute call into get_pickrecords_() picking fails again) Lego Island works on this GPU though, with the HW device. I can select the lego plants at least, although clicking them is unreliable. Big thanks to itsmattkc for the video in bug 10729, comment 17. I would never have thought of drag and dropping the photo onto the track, or listening to the Lego dude blather forever. Long story short? I guess this is yet another weirdo bug in my 20 years old GPU driver in a by then already outdated and rarely used feature. We should probably accept zero pick results as broken in a way that doesn't pollute the test too much. I attached a diff that made parts of the test work: [urk.diff](/uploads/749fcb673c6a758f7534046413d5e4c7/urk.diff) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3422#note_64049

1 0