June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/7] MR5717: Improve dmo_wrapper_sink_Receive. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

1 0

Re: [PATCH v2 0/1] MR5800: gdi32/text: Handle null partial extents pointer in GetTextExtentExPointW(). - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5800

1 0

Re: [PATCH v2 0/1] MR5802: dwrite/tests: Fix a test failure on some Win10 machines with CJK locales. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5802

1 0

Re: [PATCH v4 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

1 0

Re: [PATCH v3 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

1 0

Re: [PATCH v3 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

1 0

Re: [PATCH v4 0/5] MR5776: win32u: Parameterize DPI in some driver calls. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) June 6, 2024

June 6, 2024

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Setting the timeout on the socket is quite expensive (requires a > wineserver call). Maybe we could store the last set timeout separate > from configure timeout and update socket timeout only when they don't match? Would this proposal be only for `read_more_data` or in the broader scope of any call to `NETCON_set_timeout`? If it is for the latter, it could be tracked in `netconn_t`. I can add that into a separate merge. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72609

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) June 6, 2024

June 6, 2024

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Do we still need it? I think that with implementation in both > `set_global_option` and `INET_SetOption`, we could simply remove those > cases from `InternetSetOptionW` fallback. If we can assume that `vtbl->SetOption` is guaranteed to handle its own implementation of each timeout (or fallback to `INET_SetOption`), I could see dropping these cases from `InternetSetOptionW`. I'll amend those changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72608

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) June 6, 2024

June 6, 2024

> Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. I'm not talking about another objects' functions, I'm talking about separate objects having the same prototypes in JS sense but being otherwise separate implementations of the same interfaces in C. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72607

1 0