June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

1 0

Re: [PATCH v3 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

1 0

Re: [PATCH v4 0/5] MR5776: win32u: Parameterize DPI in some driver calls. - approved
by Alexandre Julliard (＠julliard) June 6, 2024

June 6, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) June 6, 2024

June 6, 2024

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Setting the timeout on the socket is quite expensive (requires a > wineserver call). Maybe we could store the last set timeout separate > from configure timeout and update socket timeout only when they don't match? Would this proposal be only for `read_more_data` or in the broader scope of any call to `NETCON_set_timeout`? If it is for the latter, it could be tracked in `netconn_t`. I can add that into a separate merge. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72609

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) June 6, 2024

June 6, 2024

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Do we still need it? I think that with implementation in both > `set_global_option` and `INET_SetOption`, we could simply remove those > cases from `InternetSetOptionW` fallback. If we can assume that `vtbl->SetOption` is guaranteed to handle its own implementation of each timeout (or fallback to `INET_SetOption`), I could see dropping these cases from `InternetSetOptionW`. I'll amend those changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72608

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) June 6, 2024

June 6, 2024

> Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. I'm not talking about another objects' functions, I'm talking about separate objects having the same prototypes in JS sense but being otherwise separate implementations of the same interfaces in C. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72607

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu June 6, 2024

June 6, 2024

On Thu Jun 6 19:05:56 2024 +0000, Jacek Caban wrote: > > In such case, instead of failing, it would call the other function > that was looked up, since it matches in IID and DISPID. It won't crash, > but I don't think it would be quite correct, either. > That's the whole point, the reason it's safe and I don't see why you > think it's incorrect. BTW, IID is intentionally abstract in my proposal; > a bit closer to the actual meaning would be to use something like > prototype ID once we have those (interface ID is just already available > and close enough). > > Continuing the above, IMO the following would make it the most robust: > we look it up as mentioned from the func_info_t's dispid and IID, and > then compare to see if it's the same `func_info_t` pointer. > Sure, but it can't compare `func_info_t`s by a pointer, it would need to > compare IID or something like that anyway. So in your proposal, the > opaque pointer serves as (ID,IID) carrier, nothing else. > > BTW, is there a reason you renamed `IWineJSDispatchHost` to just > `IJSDispatchHost` when it's Wine's own interface? I thought it's better > to avoid ambiguity with a native interface, especially if we're to > extend it (obviously we can't touch native interfaces), makes it a lot > more obvious. > It's all Wine code, I don't see how putting "wine" in random places > makes it any cleaner, but it's not a strong preference and I won't > insist either way. Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. As for Wine prefix, we typically have that already for our own custom interfaces in mshtml, and even though it's all Wine code, it makes it clearer for someone unfamiliar to understand that the interface is not something from Windows—so they can find its documentation/code in Wine code with grep instead of a Google search, and can freely change them around, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72606

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) June 6, 2024

June 6, 2024

> In such case, instead of failing, it would call the other function that was looked up, since it matches in IID and DISPID. It won't crash, but I don't think it would be quite correct, either. That's the whole point, the reason it's safe and I don't see why you think it's incorrect. BTW, IID is intentionally abstract in my proposal; a bit closer to the actual meaning would be to use something like prototype ID once we have those (interface ID is just already available and close enough). > Continuing the above, IMO the following would make it the most robust: we look it up as mentioned from the func_info_t's dispid and IID, and then compare to see if it's the same `func_info_t` pointer. Sure, but it can't compare `func_info_t`s by a pointer, it would need to compare IID or something like that anyway. So in your proposal, the opaque pointer serves as (ID,IID) carrier, nothing else. > BTW, is there a reason you renamed `IWineJSDispatchHost` to just `IJSDispatchHost` when it's Wine's own interface? I thought it's better to avoid ambiguity with a native interface, especially if we're to extend it (obviously we can't touch native interfaces), makes it a lot more obvious. It's all Wine code, I don't see how putting "wine" in random places makes it any cleaner, but it's not a strong preference and I won't insist either way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72605

1 0

[PATCH v2 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile().
by Paul Gofman (＠gofman) June 6, 2024

June 6, 2024

-- v2: kernelbase: Preprocess wildcarded mask and pass it with NtQueryDirectoryFile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

3 14

[PATCH v36 0/2] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 6, 2024

June 6, 2024

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v36: ucrtbase: Fix incorrect layout of FILE. ucrtbase: Add FILE structure tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 3