June 2024 - Wine-GitLab - list.winehq.org

[PATCH v12 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) June 6, 2024

June 6, 2024

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v12: kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 7

[PATCH 0/1] MR5800: gdi32/text: Handle null partial extents pointer in GetTextExtentExPointW().
by Nikolay Sivov (＠nsivov) June 6, 2024

June 6, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56788 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5800

3 2

[PATCH 0/1] MR5651: winex11.drv: Use NtUserShowWindow() instead of WM_SYSCOMMAND to synchronize window state.
by Dmitry Timoshkov (＠dmitry) June 6, 2024

June 6, 2024

DefWindowProc(WM_SYSCOMMAND) handler ignores commands for a WS_DISABLED window which leads to window state/size mismatch on X11 and win32 sides. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5651

4 7

[PATCH 0/1] MR5802: dwrite/tests: Fix a test failure on some Win10 machines with CJK locales.
by Nikolay Sivov (＠nsivov) June 6, 2024

June 6, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5802

2 1

[PATCH v2 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build.
by Dmitry Timoshkov (＠dmitry) June 6, 2024

June 6, 2024

I have a .Net application that during handling of WM_NCPAINT for one of its windows genarates exception "Arithmetic operation resulted in an overflow.". This happens only in a 64-bit prefix and only for WPARAM that contains an HRGN handle with value over than 0x7fffffff. The application does the following: public static IntPtr GetNativeDC(Message m, IntPtr handle) { if (m.Msg != 0x85) // WM_NCPAINT { return NUser32.GetWindowDC(handle); } int num = 0x200013; // DCX_VALIDATE | DCX_CLIPSIBLINGS | DCX_CACHE | DCX_WINDOW IntPtr intPtr = IntPtr.Zero; IntPtr wParam = m.WParam; if (wParam.ToInt32() != 1) { num |= 0x80; // DCX_INTERSECTRGN intPtr = CreateRectRgn(0, 0, 1, 1); CombineRgn(intPtr, wParam, IntPtr.Zero, 5); // RGN_COPY } return NUser32.GetDCEx(handle, intPtr, num); } The exception is generated by wParam.ToInt32(). MSDN description for ToInt32() https://learn.microsoft.com/en-us/dotnet/api/system.intptr.toint32?view=net… states Exceptions OverflowException In a 64-bit process, the value of this instance is too large or too small to represent as a 32-bit signed integer. MSDN also has a reference to ToInt32() source: https://github.com/dotnet/runtime/blob/5535e31a712343a63f5d7d796cd874e563e5… public int ToInt32() { #if TARGET_64BIT return checked((int)_value); #else return (int)_value; #endif } It's not clear why a sign extension may lead to an overflow exception. This patch fixes the problem, and provides a test case that confirms that entry.Generation field of a GDI32 object is limited by 127 on a 64-bit platform, while 32-bit Windows doesn't have such a limitation. -- v2: win32u: Limit GDI object generation by 128. https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

4 6

[PATCH 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) June 6, 2024

June 6, 2024

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

2 8

[PATCH v2 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process.
by Dmitry Timoshkov (＠dmitry) June 6, 2024

June 6, 2024

[test_WaitForInputIdle.tar.bz2](/uploads/a20c5b119741cd7b0b4813488854a992/test_WaitForInputIdle.tar.bz2) Attached test replicates the problem. Basically the application does process = OpenProcess(SYNCHRONIZE | PROCESS_QUERY_INFORMATION, FALSE, GetCurrentProcessId()); ret = WaitForInputIdle(process, 0x7fffffff); assert(ret == 0); With current wine.git WaitForInputIdle() returns WAIT_FAILED because the server call get_process_idle_event() refuses to return idle_event for the current process. If that limitation is removed then wineserver crashes, and other parts of the patch fix the crash. -- v2: server: Remove limitation for waiting on idle_event of the current process. https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

3 3

[PATCH v2 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon June 6, 2024

June 6, 2024

Instead of accessing the surface with macdrv_get_surface_display_image. -- v2: winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

1 6

[PATCH v5 0/4] MR5741: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) June 6, 2024

June 6, 2024

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am thinking that for more straightforward integration with the keyboard repeat SPI parameters, the request should only support the `enable` flag and the server should query the SPI registry values to get `delay` and `period` when needed. I am wondering if there any caveats here since I don't see other code in the server querying registry values (well, except to implement the registry requests themselves). Also, I would hope that opening and caching the `HKCU\Control Panel\Keyboard` hkey would remove most of the cost of performing this operation (if that's even a concern at all). -- v5: win32u: Implement keyboard auto-repeat using new server request. server: Implement key auto-repeat request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

3 6

[PATCH v6 0/4] MR5741: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) June 6, 2024

June 6, 2024

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am thinking that for more straightforward integration with the keyboard repeat SPI parameters, the request should only support the `enable` flag and the server should query the SPI registry values to get `delay` and `period` when needed. I am wondering if there any caveats here since I don't see other code in the server querying registry values (well, except to implement the registry requests themselves). Also, I would hope that opening and caching the `HKCU\Control Panel\Keyboard` hkey would remove most of the cost of performing this operation (if that's even a concern at all). -- v6: win32u: Implement keyboard auto-repeat using new server request. server: Implement key auto-repeat request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

2 5