June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacek Caban (＠jacek) June 5, 2024

June 5, 2024

Jacek Caban (@jacek) commented about dlls/wininet/http.c: > > if (maxlen == -1) maxlen = sizeof(req->read_buf); > > + NETCON_set_timeout(req->netconn, FALSE, req->hdr.receive_timeout); Setting the timeout on the socket is quite expensive (requires a wineserver call). Maybe we could store the last set timeout separate from configure timeout and update socket timeout only when they don't match? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72541

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacek Caban (＠jacek) June 5, 2024

June 5, 2024

Jacek Caban (@jacek) commented about dlls/wininet/internet.c: > + if (!lpwhh) > + { > + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); > + return FALSE; > + } > + if (!lpBuffer || dwBufferLength != sizeof(ULONG)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + ret = FALSE; > + } > + else > + { > + lpwhh->connect_timeout = *(ULONG *)lpBuffer; > + } > + break; > + } Do we still need it? I think that with implementation in both `set_global_option` and `INET_SetOption`, we could simply remove those cases from `InternetSetOptionW` fallback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72540

1 0

[PATCH v2 0/3] MR5685: Implement MarkupServices_ParseString
by Santino Mazza (＠tati1454) June 5, 2024

June 5, 2024

-- v2: mshtml: Implement MarkupServices_ParseString. mshtml: Implement MarkupServices_CreateMarkupContainer. mshtml/tests: Test for IMarkupServices. https://gitlab.winehq.org/wine/wine/-/merge_requests/5685

5 11

[PATCH 0/1] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) June 5, 2024

June 5, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 6

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) June 5, 2024

June 5, 2024

> But it was still ambiguous as I explained. If you mean the "zoom" example, I'd appreciate for some details. That one should already use `IHTMLCSSStyleDeclaration` interface, not `IHTMLStyle*` ones. > But since we pass the mshtml-internal tid (called iid in args) which is opaque to jscript, I don't really see why this is better than passing the `func_info_t` directly? Well IMO passing the pair is already more complex and requires more lookups, more args, etc, but that's just me. `get_dispex_from_this` is one thing, going through the interface take cares of that. For that part, you could just replace the argument in my branch. But we should also somehow make sure that the hook is safe to call. By binding function info to the exact object instance, we guarantee that it's safe to call `impl_from_*` from hooks. If you accept any function info as an input, you need to somehow validate that it's safe to call it. Something like moving QI earlier would only partially mitigate that. I'm open to other approaches, but unless I'm missing something, there is no such validation in your current branch. It seems to me that things like 1ffeaa446613 come from some variation of solution to that problem. Maybe it was needed in earlier version, but it shouldn't be needed with "this" being resolved on jscript side. It's no longer arbitrary when it's used for a `IJSDispatchHost` call. I would suggest to try removing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72533

1 0

Re: [PATCH v2 0/1] MR5758: ntdll: On macOS, check for xattr existence before calling getxattr. - approved
by Alexandre Julliard (＠julliard) June 5, 2024

June 5, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5758

1 0

Re: [PATCH v6 0/3] MR5737: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name. - approved
by Alexandre Julliard (＠julliard) June 5, 2024

June 5, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue. - approved
by Alexandre Julliard (＠julliard) June 5, 2024

June 5, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792

1 0

Re: [PATCH v4 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u. - approved
by Alexandre Julliard (＠julliard) June 5, 2024

June 5, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5782

1 0

Re: [PATCH v2 0/6] MR5763: wined3d: Fix some corner cases in the FFP pipelines related to unbound streams. - approved
by Alexandre Julliard (＠julliard) June 5, 2024

June 5, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5763

1 0