July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Nikolay Sivov (＠nsivov) July 31, 2024

July 31, 2024

If this is coming from analyzer report, I wouldn't bother. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_77430

1 0

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) July 31, 2024

July 31, 2024

@huw Sorry for the random ping, but I'm still looking for someone to review this change, would you mind taking a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_77429

1 0

[PATCH 0/6] MR6136: wined3d: Feed FFP shader constants through push constant buffers, part 5.
by Elizabeth Figura (＠zfigura) July 31, 2024

July 31, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6136

4 8

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Zhiyi Zhang (＠zhiyi) July 31, 2024

July 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > return STATUS_SUCCESS; > } > > -/* parse the desktop size specification */ > -static BOOL parse_size( const WCHAR *size, DWORD *width, DWORD *height ) I don't think you're going in the right direction. Why did you remove all this code? You should be able to parse the resolution from the command line and set it as the resolution for the virtual desktop window and resolve the regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77420

1 0

[PATCH v5 0/2] MR6145: comctl32: Implement PSN_QUERYINITIALFOCUS
by Jacob Czekalla (＠JacobCzekalla) July 31, 2024

July 31, 2024

Adding PSN_QUERYINITIALFOCUS helped fix some focus issues with the property sheet in bug 54862. Previously the listview in the tab control did not get focus from the start when it should have. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54862 -- v5: comctl32: Add handling for PSN_QUERYINITIALFOCUS in prop.c. comctl32/tests: Add test for PSN_QUERYINITIALFOCUS for the propsheet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6145

4 5

[PATCH v3 0/2] MR6146: comctl32: Create all prop sheet pages on initialization.
by Jacob Czekalla (＠JacobCzekalla) July 31, 2024

July 31, 2024

Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. -- v3: comctl32: Create all prop sheet pages on initialization. comctl32/tests: Add test for propsheet page creation when propsheet gets initialized. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

3 7

[PATCH v6 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) July 31, 2024

July 31, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v6: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 1

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command.
by eric pouech (＠epo) July 31, 2024

July 31, 2024

1) It's not a high priority for me to fix white space discrepancies in printing (unless there's a program in the wild that makes use of it) (I would be more worried about a space before the = as it wwould impact the saved environment variable) 2) would you mind adding a test case for this so that we don't lose this use case? 3) I strongly believe SET (and not only SET /P) shall rely on parsing the parameters with the usual helper functions instead of doing their own parsing 4) there's also a more annoying issue like not expanding in SET the potential variables inside quotes (like SET "%foo%=bar", and IIRC Wine doesn't expand %foo%, but it does expand in SET %foo%=bar) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170#note_77392

1 0

Re: [PATCH v10 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions - approved
by Alexandre Julliard (＠julliard) July 30, 2024

July 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

1 0

Re: [PATCH v6 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory. - approved
by Alexandre Julliard (＠julliard) July 30, 2024

July 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

1 0