July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR6170: programs/cmd: Fix test failures for SET /P command. - approved
by Alexandre Julliard (＠julliard) July 29, 2024

July 29, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6170

1 0

Re: [PATCH v2 0/1] MR6168: gdiplus: fixed second order adding offset and result ternary operator - approved
by Alexandre Julliard (＠julliard) July 29, 2024

July 29, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6168

1 0

[PATCH 0/1] MR6173: d3dx9: Don't silently ignore d3dx_calculate_pixel_size() errors.
by Matteo Bruni (＠Mystral) July 29, 2024

July 29, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6173

2 2

[PATCH 0/1] MR6172: kernel32: Add SetFirmwareEnvironmentVariableA stub.
by Fabian Maurer (＠DarkShadow44) July 29, 2024

July 29, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6172

3 2

[PATCH v3 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) July 29, 2024

July 29, 2024

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v3: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH 0/1] MR6168: gdiplus: fixed second order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) July 29, 2024

July 29, 2024

I'm sorry that I didn't notice this problem earlier and didn't squash commits. I found exactly same misprint in same file as in this PR: https://gitlab.winehq.org/wine/wine/-/merge_requests/6161 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6168

4 3

[PATCH v2 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) July 29, 2024

July 29, 2024

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v2: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

3 3

[PATCH v2 0/1] MR6146: comctl32: Create all prop sheet pages on initialization.
by Jacob Czekalla (＠JacobCzekalla) July 29, 2024

July 29, 2024

Fixes bug 54861. The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. -- v2: comctl32: Create all prop sheet pages on initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

2 2

[PATCH v5 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) July 29, 2024

July 29, 2024

-- v5: shell32: Fix FO_MOVE when destination has conflicting directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

[PATCH 0/1] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) July 29, 2024

July 29, 2024

The listview wine bug 56140 is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 4