June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/2] MR8299: gitlab: Remove name containing CI environment variables in windows tests. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8299

1 0

Re: [PATCH v2 0/1] MR8395: winetest: Fail just if output_size exceeds the limit. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8395

1 0

Re: [PATCH v2 0/6] MR8398: server: Use an event sync for thread and process objects. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8398

1 0

Re: [PATCH v2 0/1] MR8400: user32/tests: Call flush_event after SetForegroundWindow calls. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8400

1 0

Re: [PATCH v2 0/1] MR8397: msi: Use LRESULT to store return value from CallWindowProcW. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8397

1 0

Re: [PATCH v2 0/1] MR8399: win32u: Use the right pointer when destroying window. - approved
by Alexandre Julliard (＠julliard) June 23, 2025

June 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8399

1 0

[PATCH v2 0/2] MR8031: winex11: Ensure initialized thread data in X11DRV_get_ic.
by Etaash Mathamsetty (＠etaash.mathamsetty) June 23, 2025

June 23, 2025

Intends to replace: https://gitlab.winehq.org/wine/wine-staging/-/blob/master/patches/winex11-i… This patch has been in proton for almost 2 years now, never realized the same code existed upstream, lol -- v2: win32u/tests: Add test for multi-thread NotifyIME. winex11: Ensure initialized thread data in X11DRV_get_ic. https://gitlab.winehq.org/wine/wine/-/merge_requests/8031

3 6

[PATCH v5 0/4] MR8390: sapi/tts: Add some SSML parsing tests and XML parsing flags support.
by Shaun Ren (＠shaunren) June 23, 2025

June 23, 2025

Used by Diablo IV's screen reader. -- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/8390

3 6

[PATCH v2 0/1] MR8404: include: Make sure to null terminate string in wine_dbg_vsprintf.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

vsnprintf isn't always guaranteed to null terminate its output, depends on the version of msvcrt used. See !8256 for more information. supersedes !8256 -- v2: include: Make sure to null terminate string in wine_dbg_vsprintf. https://gitlab.winehq.org/wine/wine/-/merge_requests/8404

2 1

[PATCH 0/1] MR8256: include: vsnprintf should always write a null terminator.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

Microsoft's documentation says: > The `vsnprintf` function always writes a null terminator, even if it truncates the output. When you use `_vsnprintf` and `_vsnwprintf`, the buffer is null-terminated only if there's room at the end (that is, if the number of characters to write is less than count). For `_UCRT` and `_MSVCR_VER >= 140`, `vsnprintf` calls `__stdio_common_vsprintf` with `_CRT_INTERNAL_PRINTF_STANDARD_SNPRINTF_BEHAVIOR`, and everything works, a null byte is appended, everything is fine. If not, `vsnprintf` calls `_vsnprintf` directly and no null byte will be added if the buffer is not big enough. This happens in, for example, kernel32. And this breaks `wine_dbg_vsprintf`, which passes result of `vsnprintf` to `strlen` and goes out-of-bound. In msvcrt.spec, we also have `vsnprintf` as an alias of `_vsnprintf`, I didn't touch that since I don't know if that's deliberate. But this alias _is_ used (by e.g. winecrt0, i think?), if this one is also wrong then it might break other things. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8256

5 7