June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Nikolay Sivov (＠nsivov) June 23, 2025

June 23, 2025

On Mon Jun 23 10:09:37 2025 +0000, Conor McCarthy wrote: > I wasn't able to prove it uses a callback, but it definitely has some > means for notifying the session, and it wasn't the event queue. Official code samples for Media Foundation sources do not have anything like that. If there is a pending request we could respond with MEMediaSample(MF_E_SHUTDOWN), and any following RequestSample will return MF_E_SHUTDOWN. Is this not enough? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107609

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Conor McCarthy (＠cmccarthy) June 23, 2025

June 23, 2025

On Mon Jun 23 10:02:49 2025 +0000, Rémi Bernon wrote: > > And we should get rid of IMFMediaShutdownNotify, I think I missed when > it was added. We should not need any custom interfaces to handle this. > IIRC it was required because shutting down the source also shuts down > its event queue, it's then not possible for the session to be reliably > notified of the shutdown without a dedicated callback. I believe > @cmccarthy checked that it's also using a direct callback on Windows. I wasn't able to prove it uses a callback, but it definitely has some means for notifying the session, and it wasn't the event queue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107608

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon June 23, 2025

June 23, 2025

> And we should get rid of IMFMediaShutdownNotify, I think I missed when it was added. We should not need any custom interfaces to handle this. IIRC it was required because shutting down the source also shuts down its event queue, it's then not possible for the session to be reliably notified of the shutdown without a dedicated callback. I believe @cmccarthy checked that it's also using a direct callback on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107607

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Nikolay Sivov (＠nsivov) June 23, 2025

June 23, 2025

We currently call session_handle_source_shutdown() for any MF_E_SHUTDOWN return value coming from any node. We should probably limit this to sources. And we should get rid of IMFMediaShutdownNotify, I think I missed when it was added. We should not need any custom interfaces to handle this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107605

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Nikolay Sivov (＠nsivov) June 23, 2025

June 23, 2025

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > } > > session->source_shutdown_handled = FALSE; > + if (session->state == SESSION_STATE_SOURCE_SHUTDOWN) > + session->state = SESSION_STATE_STOPPED; > Should we merge "source_shutdown_handled" into this new state? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107604

1 0

[PATCH 0/4] MR8389: comctl32: Implement OBJID_QUERYCLASSNAMEIDX for more controls.
by Esme Povirk (＠madewokherd) June 23, 2025

June 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8389

3 6

[PATCH 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon June 23, 2025

June 23, 2025

This should fix some spurious test failure in `test_media_session_Close`, as sometimes the source shutdown happens quickly enough and changes the session state to SESSION_STATE_STOPPED, causing the later Close command to succeed when it consistently returns E_SHUTDOWN on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402

1 2

[PATCH 0/4] MR8401: gdi32: Use the maximum number of colours when biClrUsed is zero.
by Zhiyi Zhang (＠zhiyi) June 23, 2025

June 23, 2025

Fix a regression from 225004e1. According to MSDN, if the biClrUsed field is zero, the bitmap should use the maximum number of colours corresponding to the value of the biBitCount member for the compression mode specified by biCompression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8401

2 5

[PATCH 0/1] MR8400: user32/tests: Call flush_event after SetForegroundWindow calls.
by Rémi Bernon June 23, 2025

June 23, 2025

Making sure the X requests to activate the windows are being send and processed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8400

1 1

[PATCH v2 0/6] MR8337: server: Simplify atom table code.
by Rémi Bernon June 23, 2025

June 23, 2025

-- v2: server: Remove unused atom pinned member. server: Keep computed atom hash in local variables. server: Use a static array for atom table hash. server: Forbid using string atom 0xc000. server: Use a count instead of last atom index. server: Use a static array for atom table atoms. https://gitlab.winehq.org/wine/wine/-/merge_requests/8337

1 7