June 2025 - Wine-GitLab - list.winehq.org

[PATCH v2 0/2] MR8031: winex11: Ensure initialized thread data in X11DRV_get_ic.
by Etaash Mathamsetty (＠etaash.mathamsetty) June 23, 2025

June 23, 2025

Intends to replace: https://gitlab.winehq.org/wine/wine-staging/-/blob/master/patches/winex11-i… This patch has been in proton for almost 2 years now, never realized the same code existed upstream, lol -- v2: win32u/tests: Add test for multi-thread NotifyIME. winex11: Ensure initialized thread data in X11DRV_get_ic. https://gitlab.winehq.org/wine/wine/-/merge_requests/8031

3 6

[PATCH v5 0/4] MR8390: sapi/tts: Add some SSML parsing tests and XML parsing flags support.
by Shaun Ren (＠shaunren) June 23, 2025

June 23, 2025

Used by Diablo IV's screen reader. -- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/8390

3 6

[PATCH v2 0/1] MR8404: include: Make sure to null terminate string in wine_dbg_vsprintf.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

vsnprintf isn't always guaranteed to null terminate its output, depends on the version of msvcrt used. See !8256 for more information. supersedes !8256 -- v2: include: Make sure to null terminate string in wine_dbg_vsprintf. https://gitlab.winehq.org/wine/wine/-/merge_requests/8404

2 1

[PATCH 0/1] MR8256: include: vsnprintf should always write a null terminator.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

Microsoft's documentation says: > The `vsnprintf` function always writes a null terminator, even if it truncates the output. When you use `_vsnprintf` and `_vsnwprintf`, the buffer is null-terminated only if there's room at the end (that is, if the number of characters to write is less than count). For `_UCRT` and `_MSVCR_VER >= 140`, `vsnprintf` calls `__stdio_common_vsprintf` with `_CRT_INTERNAL_PRINTF_STANDARD_SNPRINTF_BEHAVIOR`, and everything works, a null byte is appended, everything is fine. If not, `vsnprintf` calls `_vsnprintf` directly and no null byte will be added if the buffer is not big enough. This happens in, for example, kernel32. And this breaks `wine_dbg_vsprintf`, which passes result of `vsnprintf` to `strlen` and goes out-of-bound. In msvcrt.spec, we also have `vsnprintf` as an alias of `_vsnprintf`, I didn't touch that since I don't know if that's deliberate. But this alias _is_ used (by e.g. winecrt0, i think?), if this one is also wrong then it might break other things. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8256

5 7

[PATCH 0/1] MR8404: include: Make sure to null terminate string in wine_dbg_vsprintf.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

vsnprintf isn't always guaranteed to null terminate its output, depends on the version of msvcrt used. See !8256 for more information. supersedes !8256 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8404

2 1

[PATCH v4 0/5] MR8390: sapi/tts: Add some SSML parsing tests and a stub SSML parser.
by Shaun Ren (＠shaunren) June 23, 2025

June 23, 2025

Used by Diablo IV's screen reader. -- v4: sapi/xml: Add a stub implementation using libxml2. sapi/tts: Support XML-related flags in ISpVoice::Speak. sapi/tests: Add some SSML tests in tts. sapi/tests: Introduce simulate_output option in tts. sapi/tests: Copy SPVTEXTFRAG list into a contiguous array. https://gitlab.winehq.org/wine/wine/-/merge_requests/8390

3 8

Re: [PATCH v5 0/6] MR8383: win32u: Move more GL drawable tracking out of the drivers. - approved
by Huw Davies (＠huw) June 23, 2025

June 23, 2025

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8383

1 0

[PATCH v11 0/7] MR6788: dlls/structuredquery part 1: Introduce new DLL, add stubs.
by Vibhav Pant (＠vibhavp) June 23, 2025

June 23, 2025

structuredquery is required to support AQS filters in Windows.Devices.Enumeration's `FindAllAsync` methods, this adds a basic set of stubs to get the ball rolling. -- v11: dlls/structuredquery: Add stubs for IQueryParserManager. dlls/structuredquery/tests: Add conformance tests for IQueryParserManager. https://gitlab.winehq.org/wine/wine/-/merge_requests/6788

3 12

[PATCH v7 0/4] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Vibhav Pant (＠vibhavp) June 23, 2025

June 23, 2025

There seem to be a few special cases here, of which the main one is `DEVPKEY_DeviceInterface_Enabled`. This property key does not have an actual registry entry, but the value read by `SetupDiGetDeviceInterfacePropertyW` corresponds to whether the interface is enabled/linked or not. Likewise, the key cannot be written to either, with `SetupDiSetDeviceInterfacePropertyW` returning `ERROR_ACCESS DENIED`. -- v7: ntoskrnl.exe/test: Add tests for SetupDiGetDeviceInterfacePropertyW with enabled interfaces. setupapi: Implement SetupDiGetDeviceInterfacePropertyW. setupapi: Implement SetupDiSetDeviceInterfacePropertyW. setupapi/tests: Add tests for SetupDi{Set,Get}DeviceInterfacePropertyW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8379

2 5

[PATCH 0/1] MR8345: Draft: windows.web/tests: Fix checking of non-null terminated json.
by Yuxuan Shui (＠yshui) June 23, 2025

June 23, 2025

check_json_ uses wcslen on the passed json string, which is no good for non-null terminated ones. It should have a length parameter. * * * (made a draft since i am not sure what this test is meant to test, see comment.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8345

3 4