May 2026 - Wine-GitLab - list.winehq.org

[PATCH v2 0/2] MR10835: gdiplus: Add support for CMYK to ARGB pixel format conversion.
by Yongjie Yao (＠yaoyongjie) May 15, 2026

May 15, 2026

Add conversion from PixelFormat32bppCMYK to PixelFormat32bppARGB in convert_pixels(), using the standard subtractive color model formula where RGB = (255 - CMY) * (255 - K) / 255. -- v2: gdiplus: Add support for CMYK to ARGB pixel format conversion. gdiplus/tests: Add test for CMYK to ARGB conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/10835

3 6

[PATCH v7 0/1] MR10704: Display invalid Indic syllables
by Aric Stewart (＠aricstewart) May 15, 2026

May 15, 2026

Use the U+25CC DOTTED CIRCLE as the base glyph for invalid Indic syllables https://bugs.winehq.org/show_bug.cgi?id=27637 -- v7: Display invalid Indic syllables https://gitlab.winehq.org/wine/wine/-/merge_requests/10704

3 5

Re: [PATCH v9 0/1] MR10528: oleaut32: Add fast paths for VarAdd and VarCmp with integer operands.
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

On Fri May 15 16:25:27 2026 +0000, Francis De Brabandere wrote: > @jacek do you need more real world evidence to pick this one up? I'm not sure about this. In general, we know that performance matters for these functions, but this is quite a narrow special case, potentially at the expense of adding more branching to other cases (although that could be mitigated with something like `!(xmask & ~(VTBIT_I2 | VTBIT_I4 | VTBIT_EMPTY))`). It is hard for me to comment further without knowing the exact bottleneck. If changing the type is the problem, perhaps some refactoring that provides a lighter version of `VariantChangeTypeEx` that does not clear/validate the output would help, both here and in other callers. I'm not sure, it would also be a larger change, so it may not be worth it. If it really comes down to special-casing, perhaps vbscript, where this case is likely the most common by far, would be a better place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10528#note_140053

1 0

[PATCH 0/1] MR10916: secur32: Return SEC_E_INVALID_TOKEN for invalid TLS record headers
by Ivan Lyugaev (＠valy) May 15, 2026

May 15, 2026

I encountered an issue with establishing an encrypted connection to the mail server in Outlook. I managed to find out that Outlook tries various connection setup options — in particular, it sends a ClientHello to server port 587, and in response receives an SMTP banner, which in the establish_context function (https://gitlab.winehq.org/wine/wine/-/blame/master/dlls/secur32/schannel.c?…) is mistakenly interpreted as TLS and returns a SEC_E_INCOMPLETE_MESSAGE error. This causes further reading of data from the server → an error and connection break. I managed to fix it by adding validation of the first bytes of the buffer to match the TLS header. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10916

4 3

Re: [PATCH v3 0/2] MR10907: vbscript: Parse &H8000 as Long(-32768) like native. - approved
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10907

1 0

[PATCH 0/2] MR10909: vbscript: Treat non-literal BSTR as greater than non-literal numeric/bool.
by Francis De Brabandere (＠francisdb) May 15, 2026

May 15, 2026

Native VBScript's BSTR-vs-numeric/bool comparison has three paths depending on compile-time literal status of each side: - numeric/bool side is a bare literal: coerce BSTR to a number (error 13 on parse failure) — already handled. - BSTR side is a bare literal, numeric/bool is not: convert numeric to its CStr form and string-compare — was previously taken unconditionally. - neither side is a literal: return BSTR > numeric/bool regardless of values — previously fell into the string-compare path, so matching stringifications like "5" = CInt(5) compared equal instead of unequal. Extend is_literal_expr to also flag EXPR_STRING so the BSTR-literal case is distinguishable from the variable case, and add the third path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10909

3 3

Re: [PATCH v7 0/2] MR10895: vbscript: Resolve UBound/LBound default member and match native errors
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > break; > - case VT_EMPTY: > - case VT_NULL: > - return MAKE_VBSERROR(VBSE_TYPE_MISMATCH); > + case VT_DISPATCH: > + hres = bound_arg_resolve_dispatch(This->ctx, V_DISPATCH(arg), &default_value); > + if(FAILED(hres)) > + return hres; > + if(V_VT(&default_value) == (VT_VARIANT|VT_ARRAY)) > + sa = V_ARRAY(&default_value); > + else if(V_VT(&default_value) == (VT_VARIANT|VT_ARRAY|VT_BYREF)) > + sa = *V_ARRAYREF(&default_value); > + else { > + VariantClear(&default_value); > + return MAKE_VBSERROR(VBSE_TYPE_MISMATCH); > + } We could resolve `VT_DISPATCH` before the switch statement. This essentially duplicates the logic from other cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10895#note_140043

1 0

Re: [PATCH v7 0/2] MR10895: vbscript: Resolve UBound/LBound default member and match native errors
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > > } > > +static HRESULT bound_arg_resolve_dispatch(script_ctx_t *ctx, IDispatch *disp, > + VARIANT *out) > +{ > + DISPPARAMS dp = {0}; > + HRESULT hres; > + > + if(!disp) > + return MAKE_VBSERROR(VBSE_OBJECT_VARIABLE_NOT_SET); > + > + VariantInit(out); > + hres = disp_call(ctx, disp, DISPID_VALUE, TRUE, &dp, out); > + if(hres == DISP_E_MEMBERNOTFOUND) > + return MAKE_VBSERROR(VBSE_OLE_NO_PROP_OR_METHOD); That mapping is already done in `map_vbs_exception`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10895#note_140042

1 0

[PATCH 0/1] MR10915: winex11: Ignore expected WM rects for shaped maximized windows
by Ivan Lyugaev (＠valy) May 15, 2026

May 15, 2026

I encountered a problem with flickering of a maximized window. I was able to determine that the issue arises from an extra call to NtUserSetWindowPos with incorrect rects. When SetWindowRgn is called, it triggers a call to NtUserSetWindowPos with SWP_NOSIZE | SWP_NOMOVE. Later, execution reaches the window_update_client_config function, where swp_flags are formed without SWP_NOSIZE | SWP_NOMOVE. These flags are formed because the rects in winex11 and win32u diverge: Win32u rect: (-4,-4)-(1924,1175) X11 desired rect: (0,0)-(1920,1171) X11 current rect: (0,0)-(1920,1171) In win32u, the rects are used after offset handling for the maximized window in the adjust_window_rect function. The formed swp_flags are passed to NtUserSetWindowPos, which causes the flickering. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10915

2 1

[PATCH 0/2] MR10885: quartz: Call GetCurrentPosition() to get the latest position before stopping the graph.
by Conor McCarthy (＠cmccarthy) May 15, 2026

May 15, 2026

Unless I missed something, info about sample delivery is not available in the quartz module, so I left this as a todo. With a typical framerate, the position set should be pretty close anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10885

3 9