May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR10897: vbscript: Allow Class declarations inline after Dim/Sub separated by ':'.
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

Jacek Caban (@jacek) commented about dlls/vbscript/compile.c: > return S_OK; > } > > +static HRESULT compile_class_statement(compile_ctx_t *ctx, class_statement_t *stat) > +{ > + if(ctx->func != &ctx->code->main_code) { I think it won't catch cases when the class is declared in inner scope. Shouldn't something like `if x then class Test ...` cause an error as well? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10897#note_140037

1 0

Re: [PATCH v3 0/1] MR10896: vbscript: Fix crash on fixed-size Dim array inside Execute called from a local scope. - approved
by Jacek Caban (＠jacek) May 15, 2026

May 15, 2026

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10896

1 0

[PATCH v10 0/4] MR8030: wineserver: Allow NtOpenFile with read-only files.
by Joel Holdsworth (＠jhol) May 15, 2026

May 15, 2026

Co-authored-by: Bernhard Übelacker <bernhardu(a)mailbox.org> -- v10: server: Don't require Unix read permission for reading only attributes. server: Open file read-only when writing only attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/8030

5 8

Re: [PATCH v11 0/2] MR10612: gdi32/uniscribe: Fix heap buffer overflow in ScriptStringAnalyse().
by समीरसिंह Sameer Singh (＠ss141309) May 15, 2026

May 15, 2026

On Fri May 15 13:50:01 2026 +0000, Huw Davies wrote: > I'm getting a bit lost with all of the uniscribe MRs. Which would be a > good next one to look at? !10672 would be the next best choice. You could also answer my [question](https://gitlab.winehq.org/wine/wine/-/merge_requests/10672#note_1… there so I could start on the riched version. There are some MRs that are not ready for review and may change (the ones related to #59680) let me mark them as draft. When this gets merged, I will rebase !10844, so that it could be reviewed next. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10612#note_140014

1 0

[PATCH v4 0/6] MR10716: dsound: Speed up resampling, part 6
by Anton Baskanov (＠baskanov) May 15, 2026

May 15, 2026

-- v4: dsound: Add an SSE version of downsample. dsound: Add an SSE version of upsample. makedep: Allow adding arch-specific sources. https://gitlab.winehq.org/wine/wine/-/merge_requests/10716

3 12

[PATCH 0/4] MR10913: Various IME fixes for FFXIV
by Marc-Aurel Zent (＠mzent) May 15, 2026

May 15, 2026

These are small fixes that make sure that FFXIV correctly sees the current input source as IME capable, so the game will display an IME icon next to its chat box (IME input actually working is independent of this). On macOS, there is no such concept as open or closed IME. Whenever an IME keyboard layout is active, we should open/close the IME that is currently active. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10913

3 6

[PATCH 0/1] MR10893: msvcrt: Avoid expensive timezone queries from plain time() calls
by Benjamin Fischer (＠bfis) May 15, 2026

May 15, 2026

The implementations of `_time32` & `_time64` internally used `_ftime64`, which also needs to query timezone information via `GetTimeZoneInformation()` which can be fairly expensive i.e. somewhere down the line is a `localtime()` call that practically always triggers at least a `stat` syscall, which is a lot of overhead for merely querying the time. This is workaround mentioned in MR !10892, for further details of the underlying issue see the description there. This MR should be fully transparent, since the return value of the `time` function(s) does not depend on the current timezone information at all. Even with MR !10892 applied, this change may still result in a speedup, just less severe since only function calls but no (further) syscall(s) are avoided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10893

3 2

Re: [PATCH v3 0/1] MR10858: Draft: vbscript: Register IDispatch as the class typeinfo's parent and lay non-default funcs first. - closed
by Francis De Brabandere (＠francisdb) May 15, 2026

May 15, 2026

This merge request was closed by Francis De Brabandere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10858

1 0

Re: [PATCH v3 0/1] MR10858: Draft: vbscript: Register IDispatch as the class typeinfo's parent and lay non-default funcs first.
by Francis De Brabandere (＠francisdb) May 15, 2026

May 15, 2026

Wine already has working GetTypeInfo. The refinements are nice-to-have. blocked on !10856 + getfuncdesc-bound, might revisit (this whole solution is not usable in libwinevbs anyway because it pulls in too much other things) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10858#note_139999

1 0

Re: [PATCH v11 0/2] MR10612: gdi32/uniscribe: Fix heap buffer overflow in ScriptStringAnalyse().
by Huw Davies (＠huw) May 15, 2026

May 15, 2026

I'm getting a bit lost with all of the uniscribe MRs. Which would be a good next one to look at? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10612#note_139996

1 0