May 2026 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10906: sapi: Implement ISpVoice::GetStatus, SetPriority and GetPriority.
by Bohdan Tkachenko (＠BohdanTkachenko) May 15, 2026

May 15, 2026

Previously these three methods returned E_NOTIMPL. SetPriority/GetPriority store the priority on the voice and validate it against SPVPRI_NORMAL, SPVPRI_ALERT and SPVPRI_OVER. GetStatus populates SPVOICESTATUS from speech_voice state: - ulCurrentStream tracks the stream currently being processed by speak_proc (set at the start of the worker so it reflects the in-flight stream, and sticks at the last processed value when idle, per MSDN). Stored as last_stream_num on speech_voice. - ulLastStreamQueued reuses the existing cur_stream_num counter, which is incremented before each Speak queues a task. - hrLastResult is the HRESULT of the most recently completed speak (set at the end of speak_proc). - dwRunningState is derived from async_wait_queue_empty(&queue, 0) so it correctly reports SPRS_DONE both when idle and after a purge clears queued tasks. This unblocks Overwatch 2's Audio Captions accessibility TTS, which calls SetPriority during voice setup and tight-polls GetStatus for SPRS_DONE between Speak calls. Add tests covering priority round-trips, GetStatus with a NULL pointer, and status fields before, during and after sync and async Speak calls. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59749 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10906

2 1

Re: [PATCH v19 0/9] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Elizabeth Figura (＠zfigura) May 14, 2026

May 14, 2026

Hi, my sincere apologies for the delay; I've had some life circumstances that have made it a bit difficult to get to review, though still that's no excuse for silence. 2/9 passes even without 1/9, and looking closer at 1/9, I'm confused at how it can have an effect. When we enumerate interfaces, we check one specific interface key or all of them. Regardless of whether we have DIGCF_ALLCLASSES or not, it shouldn't be possible to list a device that has no interfaces. Does this commit actually make a difference for the application? It may be worth splitting into a separate merge request anyway. From 6/9: ``` + found_child = FALSE; + for (entry = buffer_w; *entry; entry += wcslen(entry) + 1) + { + /* PnP instance IDs are case-insensitive; the driver reports + * "Wine\\Test" while other SetupAPI paths uppercase-normalise. */ + if (!wcsicmp(entry, L"Wine\\Test\\1")) + { + found_child = TRUE; + break; + } + } + ok(found_child, "expected Wine\\Test\\1 in DEVPKEY_Device_Children\n"); + SetupDiDestroyDeviceInfoList(bus_set); ``` We've had applications be sensitive to case before. I would prefer to test the proper case instead of using wcsicmp(). And, can't we compare the whole list exactly? We control what children this device has. DEVPKEY_Device_Siblings is still missing a test. From 9/9: ``` + /* CM_Get_Parent on a registered device. The parent property is set by + * the PnP manager during bus enumeration; manually created devices may + * not have it, so CR_NO_SUCH_DEVNODE is acceptable. */ + ret = SetupDiRegisterDeviceInfo(set, &device, 0, NULL, NULL, NULL); + ok(ret, "SetupDiRegisterDeviceInfo failed: %#lx\n", GetLastError()); + + parent = 0; + ret = CM_Get_Parent(&parent, device.DevInst, 0); + ok(ret == CR_SUCCESS || ret == CR_NO_SUCH_DEVNODE, + "CM_Get_Parent: got %#lx\n", ret); ``` Does this imply that we always get CR_NO_SUCH_DEVNODE in practice here? Or is it really variable for some reason? If the former, this test doesn't seem particularly useful where it is, and it should probably be run on the ntoskrnl device instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_139902

1 0

[PATCH 0/3] MR10903: ntdll: Add support for ARM64EC cooperative suspend.
by Jacek Caban (＠jacek) May 14, 2026

May 14, 2026

When running simulated code, instead of suspending a thread immediately, the kernel sets a registered doorbell, expecting the jit to stop execution as soon as it reaches a consistent state that can be represented as an x86_64 context. Based on patch by @bylaws. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10903

2 3

[PATCH 0/2] MR10902: vbscript: Raise err 94 on Cxxx(Null) and err 91 on Cxxx(Nothing).
by Francis De Brabandere (＠francisdb) May 14, 2026

May 14, 2026

Native cscript raises VBSE_ILLEGAL_NULL_USE (94) when Null is passed to a Cxxx coercion builtin, and VBSE_OBJECT_VARIABLE_NOT_SET (91) for Nothing. Wine was returning whatever VariantChangeType bubbled up (DISP_E_TYPEMISMATCH -> 13, DISP_E_BADVARTYPE -> 458). Factor the checks into a single helper and run it at the top of each Cxxx builtin. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10902

2 2

[PATCH v2 0/2] MR10901: vbscript: Coerce BSTR operands of And/Or/Imp to number-or-Boolean.
by Francis De Brabandere (＠francisdb) May 14, 2026

May 14, 2026

Native VarXor already converts a BSTR operand to VT_I4 when it parses as a number, falling back to VT_BOOL otherwise; VarAnd, VarOr and VarImp do not. That left expressions like ""1"" And ""2"" producing Boolean[True] in Wine instead of native's Long[0]. Apply the same coercion in interp_and / interp_or / interp_imp before calling oleaut32 so the bitwise result type matches. -- v2: vbscript: Coerce BSTR operands of And/Or/Imp to number-or-Boolean. vbscript/tests: Add tests for And/Or/Imp with BSTR operands. https://gitlab.winehq.org/wine/wine/-/merge_requests/10901

2 2

[PATCH 0/2] MR10901: Draft: vbscript: Coerce BSTR operands of And/Or/Imp to number-or-Boolean.
by Francis De Brabandere (＠francisdb) May 14, 2026

May 14, 2026

Native VarXor already converts a BSTR operand to VT_I4 when it parses as a number, falling back to VT_BOOL otherwise; VarAnd, VarOr and VarImp do not. That left expressions like ""1"" And ""2"" producing Boolean[True] in Wine instead of native's Long[0]. Apply the same coercion in interp_and / interp_or / interp_imp before calling oleaut32 so the bitwise result type matches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10901

2 2

Re: [PATCH v2 0/5] MR10806: wineandroid: switch ioctl handling to socket-based transport (part of !10569) - approved
by Alexandre Julliard (＠julliard) May 14, 2026

May 14, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10806

1 0

Re: [PATCH v5 0/4] MR10866: Report FILE_SUPPORTS_OPEN_BY_FILE_ID - approved
by Alexandre Julliard (＠julliard) May 14, 2026

May 14, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10866

1 0

Re: [PATCH v2 0/1] MR10890: winex11.drv: Use hwnd_drop instead of hwnd in x11drv_dnd_drop_event. - approved
by Alexandre Julliard (＠julliard) May 14, 2026

May 14, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10890

1 0

Re: [PATCH v2 0/3] MR10828: winmm: Fix voicecom IMMDevice leak in device enumeration. - approved
by Alexandre Julliard (＠julliard) May 14, 2026

May 14, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10828

1 0