- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Alfred Agrell (＠Alcaro) March 13, 2026

March 13, 2026

Alfred Agrell (@Alcaro) commented about dlls/ntdll/unix/signal_x86_64.c: > } > > > -#ifdef __APPLE__ > +#if defined(__APPLE__) || defined(PR_SET_SYSCALL_USER_DISPATCH) > /********************************************************************** > * sigsys_handler > * > * Handler for SIGSYS, signals that a non-existent system call was invoked. > * Only called on macOS 14 Sonoma and later. Update this comment maybe? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132226

1 0

Re: [PATCH v2 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

The maybe touchy part of this feature is the logic to find and exclude libc. This is necessary because of sigreturn. (It would also be necessary because of the syscalls made from sigsys_handler itself, namely arch_prctl and the write generated by TRACE, but we could flip the toggle to avoid these.) Returning from the SIGSYS handler will jump back into PE code, but it does so using the sigreturn syscall, which itself will generate SIGSYS otherwise. We cannot flip the toggle after jumping back to PE code. The "exclusion area" was designed to address this exact problem. The proposed approach of dl_iterate_phdr() looks reasonable to me; it relies on documented APIs, and only needs to hardcode the name of libc. If we can't find libc for any reason (e.g. because the name is different, or it's statically linked), we simply don't use SUD. Still, concerns have been raised that this might seem too hacky, so for the sake of completeness here are the alternative approaches I see: * Instead of using dl_iterate_phdr(), parse /proc/self/maps. This is largely the same approach, but would avoid a hypothetical situation where for some reason dl_iterate_phdr() is hooked but the sigreturn syscalls are still in libc. I don't think we know of such a situation though. On the other hand, it would also avoid depending on glibc, instead using more Linux-specific interfaces. I doubt that this is the only glibc-specific logic in Wine, though. * Implement upstream a libc interface to return the area that must be excluded, or, more likely, an interface that simply establishes SUD without any exclusion area, and lets libc establish the exclusion area itself. This will take some time, of course. If this patch seems too hacky, or even "maybe hacky" such that judgement cannot be passed, I would appreciate an evaluation if any of these alternatives seems definitely better, or if none of them do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330#note_132225

1 0

[PATCH 0/1] MR10330: ntdll: Implement syscall emulation on Linux using Syscall User Dispatch.
by Elizabeth Figura (＠zfigura) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10330

2 1

[PATCH v3 0/1] MR10318: Draft: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- v3: vbscript: Allow trailing End If in Else and ElseIf blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

2 1

[PATCH 0/5] MR10255: dsound: Speed up resampling, part 4
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10255

3 14

Re: [PATCH v3 0/1] MR10309: vbscript: Split() should return an empty array for empty strings.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

@julliard will this automatically close the referenced wine-bug? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10309#note_132203

1 0

[PATCH v2 0/1] MR10318: Draft: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- v2: vbscript/tests: Add tests for trailing End If in Else and ElseIf blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

2 2

Re: [PATCH v3 0/1] MR10293: Fix crashes when for_ctrl->set is empty
by eric pouech (＠epo) March 13, 2026

March 13, 2026

two comments on on-going work (thanks for taking care of it): * I believe it's cleaner to dup the empty string in node_builder_parse (that would save a reallocation on every other set) * it's possible you cannot write tests as the crash happens only a) when run from a batch file, b) when echo mode in ON (and most of the tests are run with echo OFF) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10293#note_132199

1 0

[PATCH v7 0/1] MR10302: vbscript: Allow Const to be used before its declaration.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Pre-collect all Const declarations by walking the statement tree before compiling, matching native behavior where constants are visible throughout their enclosing scope. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56931 -- v7: vbscript: Allow Const to be used before its declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10302

2 1

Re: [PATCH v4 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

On Fri Mar 13 12:56:24 2026 +0000, Francis De Brabandere wrote: > removed and rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10310#note_132187

1 0