- Wine-GitLab - list.winehq.org

[PATCH 0/3] MR10631: usp10/tests: Update to new fallback fonts.
by समीरसिंह Sameer Singh (＠ss141309) April 28, 2026

April 28, 2026

Updated the test cases for https://gitlab.winehq.org/wine/wine/-/merge_requests/10630 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10631

2 4

[PATCH 0/2] MR10630: gdi32/uniscribe: Update fallback fonts to use Noto fonts.
by समीरसिंह Sameer Singh (＠ss141309) April 28, 2026

April 28, 2026

This aligns uniscribe with dwrite behaviour and ensures better out of the box experience for systems where Microsoft fonts are typically unavailable. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27641 Regarding the "Update the script tag for Tamil" commit, the proper solution would be to mimic dwrite and use an array for the script tags and adjust the functions accordingly. I did not do this in the hope that in the future both uniscribe and dwrite will utilise Harfbuzz. This would fix a lot more issues including this. The current solution is a band-aid, so that atleast the tests pass and the font is visible when typed. The updated tests will be in a separate MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10630

3 7

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Jon Koops (＠jonkoops) April 28, 2026

April 28, 2026

Thanks for the review @Mystral, I'll see if I can incorporate the feedback. As for the style of the tests, what would you like it to look like? I used the existing tests for dsound as a reference to implement the new ones added here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137962

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

The MR looks good in principle. It's a bit unfortunate that you happened to follow the style of older tests, which I find quite ugly, but alas. One thing that I'd like to see here is a second "instance" of the same test but checking `DirectSoundCreate8()` (see dsound8.c). It's probably unlikely that it will show different results, but this is a good time to look for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137960

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

On Tue Apr 28 10:49:16 2026 +0000, Jon Koops wrote: > Also note that DirectSoundDevice-\>ref can now be cleaned up, as there > isn't any actual ref counting happening anymore, it is only ever set to > 1, and then set to 0, which immediately destroys the device right after. > However, I have opted to keep that cleanup out of this PR to keep it > simple to review. I'll see if that can be handled in a follow up PR. Thumb up on that. I'll also point out that `DirectSoundDevice` is not a public API but just an internal object, so this refcounting (or lack thereof) is not going to affect anything visible outside. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137959

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + { > + rc=IDirectSoundBuffer_GetVolume(primary2,&vol); > + ok(rc==DS_OK, > + "IDirectSoundBuffer_GetVolume(primary2) failed: %08lx\n",rc); > + } > + > + /* Verify dso2's primary buffer has CTRLVOLUME */ > + ZeroMemory(&bufcaps, sizeof(bufcaps)); > + bufcaps.dwSize=sizeof(bufcaps); > + rc=IDirectSoundBuffer_GetCaps(primary2,&bufcaps); > + ok(rc==DS_OK,"IDirectSoundBuffer_GetCaps(primary2) failed: %08lx\n",rc); > + if (rc==DS_OK) { > + todo_wine > + ok(bufcaps.dwFlags & DSBCAPS_CTRLVOLUME, > + "primary2 should have DSBCAPS_CTRLVOLUME: %08lx\n",bufcaps.dwFlags); > + } ```suggestion:-9+0 memset(&caps, 0, sizeof(caps)); caps.dwSize = sizeof(caps); hr = IDirectSoundBuffer_GetCaps(primary2, &caps); ok(hr == DS_OK, "Unexpected hr %08lx\n", hr); todo_wine ok(bufcaps.dwFlags & DSBCAPS_CTRLVOLUME, "Unexpected dwFlags %08lx\n", caps.dwFlags); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137958

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + "IDirectSound_CreateSoundBuffer(dso2) failed: %08lx\n",rc); > + if (rc!=DS_OK || primary2==NULL) > + goto RELEASE1; > + > + /* Check whether the two IDirectSound objects share a primary buffer */ > + todo_wine > + ok(primary1!=primary2, > + "Two IDirectSound objects should have independent primary buffers\n"); > + > + /* GetVolume on dso2's primary buffer should succeed */ > + todo_wine > + { > + rc=IDirectSoundBuffer_GetVolume(primary2,&vol); > + ok(rc==DS_OK, > + "IDirectSoundBuffer_GetVolume(primary2) failed: %08lx\n",rc); > + } ```suggestion:-6+0 hr = IDirectSoundBuffer_GetVolume(primary2, &vol); todo_wine ok(hr == DS_OK, "Unexpected hr %08lx\n", hr); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137957

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) > + return; > + > + rc=DirectSoundCreate(NULL,&dso2,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) { > + IDirectSound_Release(dso1); > + return; > + } > + > + rc=IDirectSound_SetCooperativeLevel(dso1,get_hwnd(),DSSCL_PRIORITY); > + ok(rc==DS_OK,"IDirectSound_SetCooperativeLevel(dso1) failed: %08lx\n",rc); > + if (rc!=DS_OK) > + goto EXIT; It doesn't look like this can legitimately fail (i.e. we leave the test only after flagging a test failure). The `if` should go. I know that there are existing tests that do exactly the same, but those should be ideally fixed and we don't want to add more of this bad pattern. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137955

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + goto EXIT; > + > + rc=IDirectSound_SetCooperativeLevel(dso2,get_hwnd(),DSSCL_PRIORITY); > + ok(rc==DS_OK,"IDirectSound_SetCooperativeLevel(dso2) failed: %08lx\n",rc); > + if (rc!=DS_OK) > + goto EXIT; > + > + /* Create a primary buffer on dso1 with CTRL3D but without CTRLVOLUME */ > + ZeroMemory(&bufdesc, sizeof(bufdesc)); > + bufdesc.dwSize=sizeof(bufdesc); > + bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER|DSBCAPS_CTRL3D; > + rc=IDirectSound_CreateSoundBuffer(dso1,&bufdesc,&primary1,NULL); > + ok(rc==DS_OK && primary1!=NULL, > + "IDirectSound_CreateSoundBuffer(dso1) failed: %08lx\n",rc); > + if (rc!=DS_OK || primary1==NULL) > + goto EXIT; Similarly here and below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137956

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + DSBCAPS bufcaps; > + LONG vol; > + > + rc=DirectSoundCreate(NULL,&dso1,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) > + return; > + > + rc=DirectSoundCreate(NULL,&dso2,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) { > + IDirectSound_Release(dso1); > + return; > + } I think we should require the second `DirectSoundCreate()` call to return successfully if the first one goes through. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137954

1 0